Stream: PassThrough?

[mattdesl]

Should this be using PassThrough instead of through2? Is there any significant gain?

scottcorgan/tap-out#11
/cc @shinnn

[shinnn]

Here is my opinion: scottcorgan/tap-out#11 (comment)

On the other hand, someone still prefer through2 for its simplicity: kevva/vinyl-assign#1 (comment)

kevva/vinyl-assign#1 (comment)

Streams3 has a simplified constructor API (nodejs/readable-stream#102) and we can use it everywhere by using readable-stream v2.0.0. That seems enough simple for me and I think now through2 is almost finishing its roles in the point of simplicity.

kevva/vinyl-assign#1 (comment)

I'm aware, but through2 still have a tiny bit simpler API, so I don't really see the benefit of switching.

[shinnn]

Is there any significant gain?

Package file size is slightly different.

$ npm i through2
$ du -sh node_modules/through2
> 364K  node_modules/through2

$ npm i readable-stream
$ du -sh node_modules/readable-stream
> 304K  node_modules/readable-stream

[yoshuawuyts]

For correctness: shouldn't this be a ReadableStream rather than a TransformStream? We're not taking any input; it's output only. Might save some issues with with the predictability of finish events (.on('finish'|'end')). from2 / from2-string is pretty good for that.

edit: for the record: from2 and friends use readable-stream under the hood 🎉

[mattdesl]

from2-string seems like a better fit for this module than through2 😄

[shinnn]

👍 from2-string