Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclosed client session at the end of tests is ugly #20

Closed
kevinkjt2000 opened this issue Jan 3, 2018 · 2 comments
Closed

Unclosed client session at the end of tests is ugly #20

kevinkjt2000 opened this issue Jan 3, 2018 · 2 comments
Assignees
@kevinkjt2000
Labels
Bug

Comments

@kevinkjt2000
Copy link
Owner 

test/test_Minecraft.py::TestMinecraft::test__removes_ansi_escapes_from_motd PASSED [ 91%]
test/test_main.py::TestMain::test__init_calls_main_once PASSED           [ 95%]
test/test_main.py::TestMain::test__main_starts_the_bot PASSED            [100%]base_events.py            1265 ERROR    Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fdd1fc9bc88>```
@kevinkjt2000
Copy link
Owner Author

The way Rapptz/discord.py handles aiohttp ClientSessions is likely the cause of this issue. There is an old version (1.0.5) being used for aiohttp, so it may not even be possible to fix this without updating that dependency upstream. Updating aiohttp in discord.py may involve fixing it ourselves, because the author seems very against doing the work.
Rapptz/discord.py#892

@kevinkjt2000 kevinkjt2000 self-assigned this Jan 8, 2018
@kevinkjt2000 kevinkjt2000 mentioned this issue Jan 8, 2018
Merged
@kevinkjt2000 kevinkjt2000 reopened this Mar 24, 2018
@kevinkjt2000
Copy link
Owner Author

Seems this issue is happening again.

@kevinkjt2000 kevinkjt2000 mentioned this issue Mar 24, 2018
Merged
kevinkjt2000 added a commit that referenced this issue Mar 24, 2018
@kevinkjt2000
feat: Bowser will keep running unless some really bad crash happens
a1d9d36 
Bowser would exit after a connection reset with the Discord API.  Now, bowser will continue to run
unless some other error happens.  This also corrects the unclosed client warning that displayed
after running tests (#20).
kevinkjt2000 added a commit that referenced this issue Mar 24, 2018
@kevinkjt2000
feat: Bowser will keep running unless some really bad crash happens
5a78156 
Bowser would exit after a connection reset with the Discord API.  Now, bowser will continue to run
unless some other error happens.  This also corrects the unclosed client warning that displayed
after running tests (#20).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinkjt2000 kevinkjt2000

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinkjt2000