-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Why do not use latest aiohttp? #892
Comments
fwiw, I've been using aiohttp 2.2.5 without issues |
I have also been using 2.2.5 without issue. |
aiohttp had a tendency to memory leak or have other issues for a while (such as the flip-flop on ClientSession being inside a coroutine), hence why the lib pinned it to a stable version that doesn't do it. |
Pinning dependencies isn't exactly strange. It's the recommended practice even. Along with what was said above, v1.0 -> v2.0 is a breaking change so it requires review before pushed through. That upgrade path had e.g. memory leaks and the like so it wasn't done. It's probably fine now but I'm not gonna unpin it. |
aiohttp is now 3.3.2. |
The latest version of aiohttp is used in the rewrite branch. The async branch no longer receives updates and will not have the requirements unpinned as the issues with the latest will not be fixed. If the latest aiohttp is a requirement, the rewrite branch is fully useable and still maintained. For more information on the rewrite branch, join the official server. |
@Rapptz v1.0 aiohttp used back in python2. As in python3 introduced new importing API therefore legacy libraries rise a warning:
Please make discord.py support latest aiohttp, let it use python3 features and help developers get rid of warnings. |
Please don't necrobump issues. Consider joining the discord.py Discord server if you want to learn more about upgrading to rewrite. |
latest aiohttp is 2.3.2 but discord.py depend on aiohttp>=1.0.0,<1.1.0
Why use old version of aiohttp? How can I use latest one?
The text was updated successfully, but these errors were encountered: