Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why do not use latest aiohttp? #892

Closed
item4 opened this issue Nov 8, 2017 · 8 comments
Closed

Question: Why do not use latest aiohttp? #892

item4 opened this issue Nov 8, 2017 · 8 comments

Comments

@item4
Copy link

item4 commented Nov 8, 2017

latest aiohttp is 2.3.2 but discord.py depend on aiohttp>=1.0.0,<1.1.0

Why use old version of aiohttp? How can I use latest one?

@khazhyk
Copy link
Collaborator

khazhyk commented Nov 9, 2017

fwiw, I've been using aiohttp 2.2.5 without issues

@EvieePy
Copy link
Contributor

EvieePy commented Nov 9, 2017

I have also been using 2.2.5 without issue.

@Fuyukai
Copy link
Contributor

Fuyukai commented Nov 9, 2017

aiohttp had a tendency to memory leak or have other issues for a while (such as the flip-flop on ClientSession being inside a coroutine), hence why the lib pinned it to a stable version that doesn't do it.

@Rapptz
Copy link
Owner

Rapptz commented Nov 9, 2017

Pinning dependencies isn't exactly strange.

It's the recommended practice even.

Along with what was said above, v1.0 -> v2.0 is a breaking change so it requires review before pushed through. That upgrade path had e.g. memory leaks and the like so it wasn't done. It's probably fine now but I'm not gonna unpin it.

@Sispheor
Copy link

aiohttp is now 3.3.2.

@ghost
Copy link

ghost commented Aug 14, 2018

The latest version of aiohttp is used in the rewrite branch. The async branch no longer receives updates and will not have the requirements unpinned as the issues with the latest will not be fixed. If the latest aiohttp is a requirement, the rewrite branch is fully useable and still maintained. For more information on the rewrite branch, join the official server.

@Philosoph228
Copy link

Philosoph228 commented Nov 6, 2018

@Rapptz v1.0 aiohttp used back in python2. As in python3 introduced new importing API therefore legacy libraries rise a warning:

C:\Program Files\Python36\lib\importlib\_bootstrap.py:219: ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__

Please make discord.py support latest aiohttp, let it use python3 features and help developers get rid of warnings.

@scarletcafe
Copy link
Contributor

Please don't necrobump issues.
aiohttp does not support Python 2 and never has. This warning comes from the fact that old versions of Cython do not include complete package data by default. You could fix this by either disabling the speedups or compiling aiohttp for yourself, but as the async branch won't be maintained for much longer, it is a better idea to just pivot to using rewrite instead.

Consider joining the discord.py Discord server if you want to learn more about upgrading to rewrite.

Repository owner locked as resolved and limited conversation to collaborators Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants