Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to include plane.watch feeder #203

Merged
merged 15 commits into from
Jan 15, 2025

Conversation

mikenye
Copy link
Contributor

@mikenye mikenye commented Jan 8, 2025

  • Update the README.md to include plane.watch
  • Create planewatch docker container
  • Create supporting scripts (eg: start.sh)
  • Add to docker-compose.yml
  • Add licenses for mutability/mlat-client and plane-watch/pw-feeder to CREDITS.md

Closes: #202

@mikenye mikenye mentioned this pull request Jan 8, 2025
@shawaj
Copy link
Collaborator

shawaj commented Jan 8, 2025

thanks @mikenye - I will test this in the next couple of days on my unit :-)

@mikenye
Copy link
Contributor Author

mikenye commented Jan 9, 2025

@shawaj I see the workflow failed, it looks like it might be a problem with the workflow itself (missing variable)?

@shawaj
Copy link
Collaborator

shawaj commented Jan 9, 2025

@shawaj I see the workflow failed, it looks like it might be a problem with the workflow itself (missing variable)?

Yeah it's a known issue (#173), don't worry 😊

@mikenye
Copy link
Contributor Author

mikenye commented Jan 9, 2025

@shawaj I see the workflow failed, it looks like it might be a problem with the workflow itself (missing variable)?

Yeah it's a known issue (#173), don't worry 😊

No problems. I'll leave this in draft status until someone is able to test or #173 is resolved.

planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Show resolved Hide resolved
planewatch/start.sh Outdated Show resolved Hide resolved
@shawaj
Copy link
Collaborator

shawaj commented Jan 14, 2025

@mikenye I think i have fixed #173 now. I think if you merge master back into your branch, or resubmit the changes as a new PR, it should re-trigger the action based on the updated/fixed version and should get the token

@mikenye
Copy link
Contributor Author

mikenye commented Jan 14, 2025

@mikenye I think i have fixed #173 now. I think if you merge master back into your branch, or resubmit the changes as a new PR, it should re-trigger the action based on the updated/fixed version and should get the token

I merged in the changes from your master branch, and the workflow has run with no issues!

@mikenye mikenye marked this pull request as ready for review January 14, 2025 03:54
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
planewatch/Dockerfile.template Outdated Show resolved Hide resolved
@Teko012 Teko012 merged commit 28db011 into ketilmo:master Jan 15, 2025
1 check passed
@mikenye
Copy link
Contributor Author

mikenye commented Jan 15, 2025

Thanks @Teko012 & @shawaj! :)

@mikenye mikenye deleted the plane-watch/initial-implementation branch January 15, 2025 08:47
ketilmo added a commit that referenced this pull request Jan 15, 2025
Thanks to Mike Nye for implementing plane.watch support (#203)! 🥳
@ketilmo
Copy link
Owner

ketilmo commented Jan 15, 2025

Thanks for making this happen! 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plane.watch?
4 participants