Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wingbits: Warning message in the logs #105

Closed
ketilmo opened this issue Jun 1, 2024 · 9 comments · Fixed by #118
Closed

[Bug] Wingbits: Warning message in the logs #105

ketilmo opened this issue Jun 1, 2024 · 9 comments · Fixed by #118
Labels
bug Something isn't working

Comments

@ketilmo
Copy link
Owner

ketilmo commented Jun 1, 2024

Over the last few weeks, a warning message has appeared in the Wingbits service logs. This is likely due to changes in the Vector service, as it appears on both new and old versions of the Wingbits feeder configuration.

This is the warning message:

WARN transform{component_kind="transform" component_id=remapped component_type=remap}: vector::transforms::remap: VRL compilation warning. warnings=
warning[E900]: unused variable `err`
ââ :1:10
â
1 â read_at, err = .now * 1000
â          ^^^ help: use the result of this expression or remove it
â
= this expression has no side-effects
= see language documentation at https://vrl.dev
= try your code in the VRL REPL, learn more at https://vrl.dev/examples

The feeding seems to work correctly.

@ketilmo ketilmo added the bug Something isn't working label Jun 1, 2024
@ketilmo ketilmo changed the title Wingbits: Warning message in the logs [Bug] Wingbits: Warning message in the logs Jun 1, 2024
@ketilmo
Copy link
Owner Author

ketilmo commented Jun 1, 2024

@shawaj Would you be able to take a look at this? Also, it would be great if you could confirm that the recent updates to Wingbits have been correctly reflected in recent changes to the balena edition.

@shawaj
Copy link
Collaborator

shawaj commented Jun 1, 2024

@ketilmo sure I'll take a look.

When you say the vector service, you mean it's been updated to a new version in later images?

@ketilmo
Copy link
Owner Author

ketilmo commented Jun 1, 2024

Thanks @shawaj! And correct. When I rolled back to an earlier deployment, the warning message disappeared. So it's likely been introduced by a recent Vector service update (via apt).

@shawaj
Copy link
Collaborator

shawaj commented Jul 1, 2024

Same issue as mentioned here https://gitlab.com/wingbits/config/-/merge_requests/22

@shawaj
Copy link
Collaborator

shawaj commented Jul 4, 2024

Pulling in latest update (i.e. clicking on deploy with balena) should fix this now.

https://gitlab.com/wingbits/config/-/blob/master/vector.yaml?ref_type=heads

@shawaj
Copy link
Collaborator

shawaj commented Jul 4, 2024

Actually probably need to bump version. I will sort a PR shortly

@ketilmo
Copy link
Owner Author

ketilmo commented Jul 5, 2024

Thanks @shawaj, much apprecaited!

@shawaj
Copy link
Collaborator

shawaj commented Jul 5, 2024

Looks like they are no longer tagging the release upstream, so latest config update is 0.0.5 but there is no tag.

@ketilmo are you happy if I just remove the tag based build and use a commit hash instead?

For example https://gitlab.com/wingbits/config/-/blob/96cb3ffb4628fbb8a128a02d691ee16bdff7f917/vector.yaml

@ketilmo
Copy link
Owner Author

ketilmo commented Jul 5, 2024

That sounds like a good approach, @shawaj! Please go ahead.

shawaj added a commit to shawaj/balena-ads-b that referenced this issue Jul 6, 2024
Bump to latest config version

Closes: ketilmo#105
@ketilmo ketilmo closed this as completed in 8abd49e Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants