Rework player collision packet manipulation #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were quite a few bug reports about players being kicked as a team was created again. This was caused by the updateToPacket method adjusting the ID of the new packet to the ID of an older one, leading to duplicated packets. Packet queueing and sending can have a large delay and lead to packets appearing out of order or after they were already replaced. This patch changes the mechanism: - Packets are not changed but new ones are created - The *last* packet is kept - OCM now does not generate random names but instead counts upwards - OCM now tries to correctly disband its own teams - A few cases in which OCM created more teams than needed were fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were quite a few bug reports about players being kicked as a team was created again.
This was caused by the updateToPacket method adjusting the ID of the new packet to the ID of an older one, leading to duplicated packets.
Packet queueing and sending can have a large delay and lead to packets appearing out of order or after they were already replaced.
This patch changes the mechanism:
References issues
Closes #457 and maybe #424, #406 and #403?