PR #17980: [keras/benchmarks/benchmark_util.py] Use var rather than string literal for is None checks on measure_performance
#18128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…tring literal for `is None` checks on `measure_performance` Imported from GitHub PR #17980 Found by running `pydocstyle` on entire codebase. Copybara import of the project: -- f7de756 by Samuel Marks <[email protected]>: [keras/benchmarks/benchmark_util.py] Use var rather than string literal for `is None` checks on `measure_performance` Merging this change closes #17980 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17980 from SamuelMarks:benchmark_util-is-check f7de756 PiperOrigin-RevId: 530510171
copybara-service
bot
force-pushed
the
test_530510171
branch
from
497e745
to
55d0331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #17980: [keras/benchmarks/benchmark_util.py] Use var rather than string literal for
is Nonechecks onmeasure_performanceImported from GitHub PR #17980
Found by running
pydocstyleon entire codebase.Copybara import of the project:
--
f7de756 by Samuel Marks [email protected]:
[keras/benchmarks/benchmark_util.py] Use var rather than string literal for
is Nonechecks onmeasure_performanceMerging this change closes #17980
FUTURE_COPYBARA_INTEGRATE_REVIEW=#17980 from SamuelMarks:benchmark_util-is-check f7de756