[keras/benchmarks/benchmark_util.py] Use var rather than string literal for is None checks on measure_performance
#17980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al for `is None` checks on `measure_performance`
google-ml-butler
bot
added
the
keras-team-review-pending
Frightera
reviewed
Apr 18, 2023
| raise ValueError("Input data is required.") | ||
| if "optimizer" is None: | ||
| elif optimizer is None: |
There was a problem hiding this comment.
Hi @SamuelMarks,
Just curiosity, why did you switch into elif instead of if? I think keeping them independent might be a better practice, i.e maintain the if statements.
P.S: Don't take this as an official-review.
There was a problem hiding this comment.
@Frightera Because it's more efficient:
$ python -m timeit 'a="foo"' 'if a == "foo":' ' a += "bar"' 'if a == "can":' ' a += "can"'
5000000 loops, best of 5: 51.9 nsec per loop
$ python -m timeit 'a="foo"' 'if a == "foo":' ' a += "bar"' 'elif a == "can":' ' a += "can"'
10000000 loops, best of 5: 39.6 nsec per loopAlso it's more logical. The compiler probably optimises the branches better, and it's clearer to read.
There was a problem hiding this comment.
Thanks, I think the speed difference is because of every if statement is executed in your example whereas in here there are ValueErrors which will cause not to execute other statements, probably the performance difference will be negligible.
google-ml-butler
bot
added
kokoro:force-run
ready to pull
fchollet
removed
the
keras-team-review-pending
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
…tring literal for `is None` checks on `measure_performance` Imported from GitHub PR #17980 Found by running `pydocstyle` on entire codebase. Copybara import of the project: -- f7de756 by Samuel Marks <[email protected]>: [keras/benchmarks/benchmark_util.py] Use var rather than string literal for `is None` checks on `measure_performance` Merging this change closes #17980 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17980 from SamuelMarks:benchmark_util-is-check f7de756 PiperOrigin-RevId: 526075166
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
…tring literal for `is None` checks on `measure_performance` Imported from GitHub PR #17980 Found by running `pydocstyle` on entire codebase. Copybara import of the project: -- f7de756 by Samuel Marks <[email protected]>: [keras/benchmarks/benchmark_util.py] Use var rather than string literal for `is None` checks on `measure_performance` Merging this change closes #17980 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17980 from SamuelMarks:benchmark_util-is-check f7de756 PiperOrigin-RevId: 526075166
gbaned
added
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
May 16, 2023
…tring literal for `is None` checks on `measure_performance` Imported from GitHub PR #17980 Found by running `pydocstyle` on entire codebase. Copybara import of the project: -- f7de756 by Samuel Marks <[email protected]>: [keras/benchmarks/benchmark_util.py] Use var rather than string literal for `is None` checks on `measure_performance` Merging this change closes #17980 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17980 from SamuelMarks:benchmark_util-is-check f7de756 PiperOrigin-RevId: 530510171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by running
pydocstyleon entire codebase.