Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the bounding box utility to be more readable #51

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Update the bounding box utility to be more readable #51

merged 3 commits into from
Jan 22, 2022

Commits on Jan 22, 2022

  1. Update the bounding box utility to be more readable 

    1. Added docstring header to contain more details about whats the formats we usually use for bounding box, and what's the math conversion between them.

2. Slight change the implementation of conversion function to be more readable. The current index slice based approach is very hard to understand.

3. Added unit test for bbox util.
    @qlzh727
    qlzh727 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    372babe View commit details
    Browse the repository at this point in the history

  2. Fix the format issue.

    @qlzh727
    qlzh727 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    eff5685 View commit details
    Browse the repository at this point in the history

  3. Fix more format issue

    @qlzh727
    qlzh727 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    bb8a826 View commit details
    Browse the repository at this point in the history