Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the bounding box utility to be more readable #51

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Update the bounding box utility to be more readable #51

merged 3 commits into from
Jan 22, 2022

Conversation

qlzh727
Copy link
Member

@qlzh727 qlzh727 commented Jan 22, 2022

  1. Added docstring header to contain more details about whats the formats we usually use for bounding box, and what's the math conversion between them.

  2. Slight change the implementation of conversion function to be more readable. The current index slice based approach is very hard to understand.

  3. Added unit test for bbox util.

@qlzh727
Update the bounding box utility to be more readable
372babe 
1. Added docstring header to contain more details about whats the formats we usually use for bounding box, and what's the math conversion between them.

2. Slight change the implementation of conversion function to be more readable. The current index slice based approach is very hard to understand.

3. Added unit test for bbox util.
@LukeWood
Copy link
Contributor

Thanks Scott! Can look this over a bit later this eve

LukeWood
LukeWood suggested changes Jan 22, 2022
View reviewed changes
Copy link
Contributor

@LukeWood LukeWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - looks like you need to locally run isort and it should be good to go.

@qlzh727 qlzh727 requested a review from LukeWood January 22, 2022 06:26
@qlzh727
Copy link
Member Author

qlzh727 commented Jan 22, 2022

Looks good - looks like you need to locally run isort and it should be good to go.

Done.

@qlzh727 qlzh727 merged commit ec4705e into keras-team:master Jan 22, 2022
@qlzh727 qlzh727 deleted the bbox-update branch January 22, 2022 06:30
ianstenbit pushed a commit to ianstenbit/keras-cv that referenced this pull request Aug 6, 2022
Update the bounding box utility to be more readable (keras-team#51)
192baae 
* Update the bounding box utility to be more readable

1. Added docstring header to contain more details about whats the formats we usually use for bounding box, and what's the math conversion between them.

2. Slight change the implementation of conversion function to be more readable. The current index slice based approach is very hard to understand.

3. Added unit test for bbox util.

* Fix the format issue.

* Fix more format issue
adhadse pushed a commit to adhadse/keras-cv that referenced this pull request Sep 17, 2022
@qlzh727
Update the bounding box utility to be more readable (keras-team#51)
0f68153 
* Update the bounding box utility to be more readable

1. Added docstring header to contain more details about whats the formats we usually use for bounding box, and what's the math conversion between them.

2. Slight change the implementation of conversion function to be more readable. The current index slice based approach is very hard to understand.

3. Added unit test for bbox util.

* Fix the format issue.

* Fix more format issue
freedomtan pushed a commit to freedomtan/keras-cv that referenced this pull request Jul 20, 2023
@haifeng-jin
re-enable imports checks (keras-team#51)
0eca3a8
freedomtan pushed a commit to freedomtan/keras-cv that referenced this pull request Jul 20, 2023
@nkovela1 @fchollet
@ariG23498 @sampathweb @chenmoneygithub @haifeng-jin @grasskin
Adds RMSprop and AdamW optimizers with associated tests. (keras-team#59)
b49e12e 
* Add golden correctness tests for Adam and SGD

* Fix dtype issues

* Sync with main (keras-team#56)

* Minor touch ups

* Fix a pretty major bug

* Format code

* Big rethink of Variable API

* Make build-by-run the default build(), leveraging new zero_history KerasTensor mode

* Minor fixes

* Format code

* Switch back to build-by-eager-run for simplicity

* Add raise upon build failure

* Work around JAX bug.

* Add a few more tests.

* Add saving tests

* Adds test suite for SGD and golden correctness tests for all optimizers (keras-team#40)

* Add golden correctness tests for Adam and SGD

* Fix dtype issues

* Add binary accuracy (keras-team#41)

* chore: adding binary accuracy

* chore: fix docstring

* Add tests for add_loss and activity regularization.

* Reformat code

* Add ActivityRegularization layer

* Fix JAX CI.

* Add Lambda Callback (keras-team#42)

* Add LambdaCallback

* Add Lambda Callback

* Add Lambda Callback

* Rename lambda_callback_test.py

* Add einsum (keras-team#43)

* Add einsum

* address comments

* Fix format line length (keras-team#45)

* Add Embedding layer

* Shorten lines

* Add .vscode to .gitignore (keras-team#46)

* rm vscode settings

* add .vscode to gitignore

* Set demo program backend (keras-team#48)

* Add tests for training arg resolution in Layer.

* Implement mixed precision.

* Replace backend.execute with backend.numpy.XXX (keras-team#50)

* Add cosine similarity loss and update l2_normalize from regularizers (keras-team#34)

* Begin cosine loss

* Add testing for cosine similarity

* Fix formatting

* Docstring standardization

* Formatting

* Create numerical_utils

* Fix issue with call context lingering.

* Add the EarlyStopping callback (keras-team#44)

* add earlystopping callback

* addressing comments

* address comments

* addressing comments

* remove unused imports

* re-enable imports checks (keras-team#51)

* Add nn.one_hot (keras-team#52)

* Add GaussianDropout layer.

* Add GaussianNoise layer

* Add Categorical Accuracy Metric (keras-team#47)

* chore: adding categorical accuracy metric

* chore: reformat docstrings

* chore: reformat

* chore: ndims with len

* refactor the docstring

* Fix typos

* Implement masking.

---------

Co-authored-by: Francois Chollet <[email protected]>
Co-authored-by: Aritra Roy Gosthipaty <[email protected]>
Co-authored-by: Ramesh Sampath <[email protected]>
Co-authored-by: Chen Qian <[email protected]>
Co-authored-by: Haifeng Jin <[email protected]>
Co-authored-by: Gabriel Rasskin <[email protected]>

* Adds rmsprop optimizer and tests

* Add AdamW optimizer and tests, minor formatting changes

* Implemented formatting fixes

---------

Co-authored-by: Francois Chollet <[email protected]>
Co-authored-by: Aritra Roy Gosthipaty <[email protected]>
Co-authored-by: Ramesh Sampath <[email protected]>
Co-authored-by: Chen Qian <[email protected]>
Co-authored-by: Haifeng Jin <[email protected]>
Co-authored-by: Gabriel Rasskin <[email protected]>
freedomtan pushed a commit to freedomtan/keras-cv that referenced this pull request Jul 20, 2023
@nkovela1 @fchollet
@ariG23498 @sampathweb @chenmoneygithub @haifeng-jin @grasskin
Adds Adagrad and Adadelta optimizers and associated tests. (keras-tea…
047485b 
…m#72)

* Add golden correctness tests for Adam and SGD

* Fix dtype issues

* Sync with main (keras-team#56)

* Minor touch ups

* Fix a pretty major bug

* Format code

* Big rethink of Variable API

* Make build-by-run the default build(), leveraging new zero_history KerasTensor mode

* Minor fixes

* Format code

* Switch back to build-by-eager-run for simplicity

* Add raise upon build failure

* Work around JAX bug.

* Add a few more tests.

* Add saving tests

* Adds test suite for SGD and golden correctness tests for all optimizers (keras-team#40)

* Add golden correctness tests for Adam and SGD

* Fix dtype issues

* Add binary accuracy (keras-team#41)

* chore: adding binary accuracy

* chore: fix docstring

* Add tests for add_loss and activity regularization.

* Reformat code

* Add ActivityRegularization layer

* Fix JAX CI.

* Add Lambda Callback (keras-team#42)

* Add LambdaCallback

* Add Lambda Callback

* Add Lambda Callback

* Rename lambda_callback_test.py

* Add einsum (keras-team#43)

* Add einsum

* address comments

* Fix format line length (keras-team#45)

* Add Embedding layer

* Shorten lines

* Add .vscode to .gitignore (keras-team#46)

* rm vscode settings

* add .vscode to gitignore

* Set demo program backend (keras-team#48)

* Add tests for training arg resolution in Layer.

* Implement mixed precision.

* Replace backend.execute with backend.numpy.XXX (keras-team#50)

* Add cosine similarity loss and update l2_normalize from regularizers (keras-team#34)

* Begin cosine loss

* Add testing for cosine similarity

* Fix formatting

* Docstring standardization

* Formatting

* Create numerical_utils

* Fix issue with call context lingering.

* Add the EarlyStopping callback (keras-team#44)

* add earlystopping callback

* addressing comments

* address comments

* addressing comments

* remove unused imports

* re-enable imports checks (keras-team#51)

* Add nn.one_hot (keras-team#52)

* Add GaussianDropout layer.

* Add GaussianNoise layer

* Add Categorical Accuracy Metric (keras-team#47)

* chore: adding categorical accuracy metric

* chore: reformat docstrings

* chore: reformat

* chore: ndims with len

* refactor the docstring

* Fix typos

* Implement masking.

---------

Co-authored-by: Francois Chollet <[email protected]>
Co-authored-by: Aritra Roy Gosthipaty <[email protected]>
Co-authored-by: Ramesh Sampath <[email protected]>
Co-authored-by: Chen Qian <[email protected]>
Co-authored-by: Haifeng Jin <[email protected]>
Co-authored-by: Gabriel Rasskin <[email protected]>

* Adds rmsprop optimizer and tests

* Add AdamW optimizer and tests, minor formatting changes

* Implemented formatting fixes

* Adds clip norm and clip value tests to Adam

* Adds Adagrad and Adadelta optimizers

* Applies fixes to formatting and deletes unnecessary kwargs

---------

Co-authored-by: Francois Chollet <[email protected]>
Co-authored-by: Aritra Roy Gosthipaty <[email protected]>
Co-authored-by: Ramesh Sampath <[email protected]>
Co-authored-by: Chen Qian <[email protected]>
Co-authored-by: Haifeng Jin <[email protected]>
Co-authored-by: Gabriel Rasskin <[email protected]>
freedomtan pushed a commit to freedomtan/keras-cv that referenced this pull request Jul 20, 2023
@nkovela1 @fchollet
@ariG23498 @sampathweb @chenmoneygithub @haifeng-jin @grasskin
Adds all remaining Keras optimizers (Adamax, Adafactor, Nadam, and Ft…
3cf0a83 
…rl) (keras-team#80)

* Add golden correctness tests for Adam and SGD

* Fix dtype issues

* Sync with main (keras-team#56)

* Minor touch ups

* Fix a pretty major bug

* Format code

* Big rethink of Variable API

* Make build-by-run the default build(), leveraging new zero_history KerasTensor mode

* Minor fixes

* Format code

* Switch back to build-by-eager-run for simplicity

* Add raise upon build failure

* Work around JAX bug.

* Add a few more tests.

* Add saving tests

* Adds test suite for SGD and golden correctness tests for all optimizers (keras-team#40)

* Add golden correctness tests for Adam and SGD

* Fix dtype issues

* Add binary accuracy (keras-team#41)

* chore: adding binary accuracy

* chore: fix docstring

* Add tests for add_loss and activity regularization.

* Reformat code

* Add ActivityRegularization layer

* Fix JAX CI.

* Add Lambda Callback (keras-team#42)

* Add LambdaCallback

* Add Lambda Callback

* Add Lambda Callback

* Rename lambda_callback_test.py

* Add einsum (keras-team#43)

* Add einsum

* address comments

* Fix format line length (keras-team#45)

* Add Embedding layer

* Shorten lines

* Add .vscode to .gitignore (keras-team#46)

* rm vscode settings

* add .vscode to gitignore

* Set demo program backend (keras-team#48)

* Add tests for training arg resolution in Layer.

* Implement mixed precision.

* Replace backend.execute with backend.numpy.XXX (keras-team#50)

* Add cosine similarity loss and update l2_normalize from regularizers (keras-team#34)

* Begin cosine loss

* Add testing for cosine similarity

* Fix formatting

* Docstring standardization

* Formatting

* Create numerical_utils

* Fix issue with call context lingering.

* Add the EarlyStopping callback (keras-team#44)

* add earlystopping callback

* addressing comments

* address comments

* addressing comments

* remove unused imports

* re-enable imports checks (keras-team#51)

* Add nn.one_hot (keras-team#52)

* Add GaussianDropout layer.

* Add GaussianNoise layer

* Add Categorical Accuracy Metric (keras-team#47)

* chore: adding categorical accuracy metric

* chore: reformat docstrings

* chore: reformat

* chore: ndims with len

* refactor the docstring

* Fix typos

* Implement masking.

---------

Co-authored-by: Francois Chollet <[email protected]>
Co-authored-by: Aritra Roy Gosthipaty <[email protected]>
Co-authored-by: Ramesh Sampath <[email protected]>
Co-authored-by: Chen Qian <[email protected]>
Co-authored-by: Haifeng Jin <[email protected]>
Co-authored-by: Gabriel Rasskin <[email protected]>

* Adds rmsprop optimizer and tests

* Add AdamW optimizer and tests, minor formatting changes

* Implemented formatting fixes

* Adds clip norm and clip value tests to Adam

* Adds Adagrad and Adadelta optimizers

* Applies fixes to formatting and deletes unnecessary kwargs

* Adds Adamax and Adafactor and associated tests

* Adds Nadam and Ftrl optimizers and associated tests

---------

Co-authored-by: Francois Chollet <[email protected]>
Co-authored-by: Aritra Roy Gosthipaty <[email protected]>
Co-authored-by: Ramesh Sampath <[email protected]>
Co-authored-by: Chen Qian <[email protected]>
Co-authored-by: Haifeng Jin <[email protected]>
Co-authored-by: Gabriel Rasskin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet Awaiting requested review from fchollet

@LukeWood LukeWood Awaiting requested review from LukeWood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qlzh727 @LukeWood