Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: describe the functional flow of a deployment #828

Closed
wants to merge 302 commits into from
Closed

docs: describe the functional flow of a deployment #828

wants to merge 302 commits into from

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Feb 13, 2023 •
edited by mowies
Loading

Signed-off-by: Meg McRoberts [email protected]

This pulls together the basic information from the slack discussion. Now I need to fill in some details. Perhaps someone can point me to places in the source code where I might dig out some more information.

Closes #689
Epic: #770

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Feb 13, 2023
@StackScribe StackScribe self-assigned this Feb 13, 2023
@StackScribe StackScribe marked this pull request as draft February 13, 2023 12:47
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 13, 2023 •
edited
Loading

Codecov Report

Merging #828 (03e1961) into main (27439ff) will increase coverage by 20.04%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #828       +/-   ##
===========================================
+ Coverage   61.26%   81.31%   +20.04%     
===========================================
  Files         138      131        -7     
  Lines       10454     7872     -2582     
===========================================
- Hits         6405     6401        -4     
+ Misses       3799     1220     -2579     
- Partials      250      251        +1

see 13 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.28% <ø> (ø)
component-tests 60.45% <ø> (-0.22%) ⬇️
keptn-lifecycle-operator ?
lifecycle-operator 80.88% <ø> (ø)
metrics-operator 77.80% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@StackScribe StackScribe mentioned this pull request Feb 15, 2023
Closed
6 tasks
@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit ffcb79f
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6450f7a11b311b000828fc35
😎 Deploy Preview https://deploy-preview-828--keptn-lifecycle-toolkit.netlify.app/docs/concepts/architecture/deployment-flow
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@agardnerIT
Copy link
Contributor

I discovered this week that KLT isn't a custom scheduler but rather a scheduler plugin. The effect is the same but to be accurate, that's what it is.

This executes a series of
Kubernetes [events](https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/event-v1/).
Events are resources such as Deployments or Pods.

kubectl apply -f deployment.yaml doesn't execute a set of events. Events are just like log lines, they exist due to some other process. It is probably good enough to say kubectl apply... begins a deployment by triggering the kubernetes pod scheduler. During this process, events are omitted.

Typo: genereta should be generate

@StackScribe StackScribe marked this pull request as ready for review April 24, 2023 21:46
@StackScribe StackScribe requested review from a team as code owners April 24, 2023 21:46
agardnerIT
agardnerIT previously approved these changes Apr 25, 2023
View reviewed changes
@mowies mowies changed the title docs: functional flow of a deployment docs: describe the functional flow of a deployment Apr 25, 2023
mowies
mowies reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change all bash code annotations to shell

docs/content/en/docs/concepts/architecture/deployment-flow.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/architecture/deployment-flow.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/architecture/deployment-flow.md Outdated Show resolved Hide resolved
mowies
mowies previously approved these changes Apr 26, 2023
View reviewed changes
renovate bot and others added 17 commits May 2, 2023 05:44
@renovate @odubajDT @StackScribe
deps: update module golang.org/x/net to v0.9.0 (#1298)
29974b6 
Signed-off-by: Renovate Bot <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@bacherfl @StackScribe
feat(operator): create KeptnAppCreationRequest in pod webhook (#1277)
99c5acc 
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@odubajDT @StackScribe
chore: bump GO_VERSION to 1.20 in pipelines (#1326)
613c2d6 
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@odubajDT @StackScribe
deps: bump denoland/deno to 1.32.5 (#1329)
9a80945 
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@odubajDT @StackScribe
chore(metrics-operator): restrict custom metrics ClusterRole privileg…
e0b6c65 
…es (#1330)

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@odubajDT @StackScribe
fix: security pipeline (#1333)
3a4b058 
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
markdownlint: add blank line
856bd71 
Signed-off-by: Meg McRoberts [email protected]

Signed-off-by: Meg McRoberts <[email protected]>
@odubajDT @StackScribe
chore(metrics-operator): add configuration parameters for container s…
cf505ad 
…ecurityContext (#1290)

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
ondrej comments
648a0b8 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
ondrej comments
a57ecf9 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
ondrej comments
4704bf0 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
add closing tics
9797d18 
Signed-off-by: Meg McRoberts [email protected]

Signed-off-by: Meg McRoberts <[email protected]>
@bacherfl @StackScribe
docs: describe automatic application discovery (#1304)
33b3875 
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
spacing
2bef5b3 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/concepts/architecture/deployment-flow.md
dcb782d 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/concepts/architecture/deployment-flow.md
dcda762 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/concepts/architecture/deployment-flow.md
03e1961 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

This was referenced May 2, 2023
Closed
Merged
@StackScribe
Copy link
Contributor Author

This PR is utterly corrupted and so is replaced by #1342

@StackScribe StackScribe closed this May 3, 2023
@StackScribe StackScribe deleted the 0211-deploy-arch branch May 3, 2023 11:17
@StackScribe StackScribe mentioned this pull request May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT requested changes

@thisthat thisthat thisthat left review comments

@agardnerIT agardnerIT agardnerIT left review comments

@mowies mowies mowies left review comments

@bacherfl bacherfl Awaiting requested review from bacherfl

@RealAnna RealAnna Awaiting requested review from RealAnna

@thschue thschue Awaiting requested review from thschue

Assignees

@StackScribe StackScribe

Labels
cert-manager documentation Improvements or additions to documentation helm metrics-operator ops scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page to describe lifecycle of events