Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security pipeline #1333

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: security pipeline #1333

merged 1 commit into from
May 2, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented May 2, 2023

Provided ignorers:

  • coreDNS poisoning: there is no DNS poisoning in our system, this is a false positive
  • data destruction: we use delete command to remove unneeded resources. This is evaluated as data destruction.
  • malicious webhook: every mutating webhook is evaluated as malicious, so it's reviewed if it's really needed. In our case there is definitely a reason for it
  • server running on 2222: Just a auto-check that port 2222 is open, we have metrics exposed on this port
  • unsigned images: we do not sign our images in pipeline builts, but that's expected

Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT requested a review from a team as a code owner May 2, 2023 06:46
@github-actions github-actions bot added the ops label May 2, 2023
@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit a42202e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6450b1cad1c33c0008af21ab
😎 Deploy Preview https://deploy-preview-1333--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1333 (a42202e) into main (ba7b679) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage   59.83%   59.83%           
=======================================
  Files         138      138           
  Lines       10461    10461           
=======================================
  Hits         6259     6259           
  Misses       3967     3967           
  Partials      235      235           

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.28% <ø> (ø)
component-tests 59.81% <ø> (ø)
lifecycle-operator 78.34% <ø> (ø)
metrics-operator 77.80% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT merged commit 79e475c into keptn:main May 2, 2023
@keptn-bot keptn-bot mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants