feat: add prometheus metrics evaluation example #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shardulsrivastava
requested review from
thisthat,
thschue and
bacherfl
as code owners
shardulsrivastava
changed the title
shardulsrivastava
force-pushed
the
feature/65/add-prometheus-metrics-function
branch
from
378e5fc to
db8a3f5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
+ Coverage 56.36% 57.38% +1.02%
==========================================
Files 82 89 +7
Lines 6683 7012 +329
==========================================
+ Hits 3767 4024 +257
- Misses 2756 2822 +66
- Partials 160 166 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
thisthat
reviewed
Jan 27, 2023
shardulsrivastava
force-pushed
the
feature/65/add-prometheus-metrics-function
branch
from
f089830 to
83337c3
Compare
|
@thisthat thanks for the review, I have addressed them and also added some error handling which i encountered during testing. |
Signed-off-by: Shardul Srivastava <[email protected]>
Signed-off-by: Shardul Srivastava <[email protected]>
Signed-off-by: Shardul Srivastava <[email protected]>
Signed-off-by: Shardul Srivastava <[email protected]>
Signed-off-by: Shardul Srivastava <[email protected]>
Signed-off-by: Shardul Srivastava <[email protected]>
shardulsrivastava
force-pushed
the
feature/65/add-prometheus-metrics-function
branch
from
606c761 to
f66d4b4
Compare
thisthat
reviewed
Jan 31, 2023
|
@shardulsrivastava thanks for the PR 👍 I have only a small final Nit to fix |
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Shardul Srivastava <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@thisthat addressed the comment. |
thisthat
approved these changes
Feb 1, 2023
mowies
approved these changes
Feb 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shardul Srivastava [email protected]
Adds a simple function for fetching metrics from Prometheus and evaluates them against a specified expected value.
Closes #65