Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create simple function for fetching metrics from prometheus #65

Closed
thschue opened this issue Sep 30, 2022 · 2 comments · Fixed by #677
Closed

Create simple function for fetching metrics from prometheus #65

thschue opened this issue Sep 30, 2022 · 2 comments · Fixed by #677
Assignees
@shardulsrivastava
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
2.0.0

Comments

@thschue
Copy link
Contributor

thschue commented Sep 30, 2022

To be able to evaluate metrics from Prometheus, there should be a simple function that fetches metrics from Prometheus, compares them with a value, and terminates either successfully(0) or failed(1) depending on the result.

Sample functions could be found at https://github.com/keptn-sandbox/lifecycle-controller/tree/main/functions-runtime/samples/ts.
@thschue thschue added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2022
@thschue thschue added this to the 1.0.x milestone Nov 2, 2022
@shardulsrivastava
Copy link
Contributor

@thschue I would like to work on this.

@mowies
Copy link
Member

mowies commented Jan 9, 2023

@shardulsrivastava sorry for the long wait... I assigned you now

@shardulsrivastava shardulsrivastava mentioned this issue Jan 23, 2023
Merged
thisthat pushed a commit that referenced this issue Feb 1, 2023
@shardulsrivastava
feat: add prometheus metrics evaluation example (#677)
e5f644c 
Co-authored-by: Giovanni Liva <[email protected]>
Closes #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shardulsrivastava shardulsrivastava

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

feat: add prometheus metrics evaluation example shardulsrivastava/lifecycle-toolkit
3 participants
@mowies @shardulsrivastava @thschue