Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce gci linter for golangci-lint #461

Merged

Conversation

philipp-hinteregger
Copy link
Contributor

@philipp-hinteregger philipp-hinteregger commented Nov 23, 2022

This PR

  • is a follow up PR of ci: add golangci-lint workflow #448
  • introduces the gci linter for golangci-lint
  • fixes new linter errors with gci write --skip-generated -s standard,default .

Related issue

Signed-off-by: Philipp Hinteregger [email protected]

Signed-off-by: Philipp Hinteregger <[email protected]>
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #461 (24100a6) into main (0855489) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   43.28%   43.28%           
=======================================
  Files          27       27           
  Lines        2116     2116           
=======================================
  Hits          916      916           
  Misses       1118     1118           
  Partials       82       82           
Impacted Files Coverage Δ
operator/controllers/common/evaluationhandler.go 0.00% <ø> (ø)
operator/controllers/common/taskhandler.go 0.00% <ø> (ø)
operator/controllers/keptnapp/controller.go 65.88% <ø> (ø)
operator/controllers/keptnappversion/controller.go 71.87% <ø> (ø)
...ers/keptnappversion/reconcile_prepostdeployment.go 81.25% <ø> (ø)
operator/controllers/keptntask/controller.go 0.00% <ø> (ø)
operator/controllers/keptntask/job_utils.go 40.00% <ø> (ø)
...or/controllers/keptnworkloadinstance/controller.go 49.46% <ø> (ø)
...keptnworkloadinstance/reconcile_deploymentstate.go 62.29% <ø> (ø)
operator/webhooks/pod_mutating_webhook.go 35.94% <ø> (ø)
... and 2 more
Flag Coverage Δ
keptn-lifecycle-operator 47.81% <ø> (ø)
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
@philipp-hinteregger philipp-hinteregger changed the title ci: introduce errlint linter for golangci-lint ci: introduce additional linters for golangci-lint Nov 23, 2022
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
@philipp-hinteregger philipp-hinteregger changed the title ci: introduce additional linters for golangci-lint ci: introduce gci linter for golangci-lint Nov 23, 2022
@philipp-hinteregger philipp-hinteregger marked this pull request as ready for review November 23, 2022 12:23
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipp-hinteregger philipp-hinteregger merged commit 29fa0e5 into keptn:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants