ci: add golangci-lint workflow #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 43.16% 43.28% +0.12%
==========================================
Files 27 27
Lines 2122 2116 -6
==========================================
Hits 916 916
+ Misses 1124 1118 -6
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. |
philipp-hinteregger
force-pushed
the
ci/391/introduce-go-linters
branch
2 times, most recently
from
057868d to
5d1c1d6
Compare
philipp-hinteregger
requested review from
thisthat,
thschue,
bacherfl,
RealAnna and
mowies
as code owners
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
philipp-hinteregger
force-pushed
the
ci/391/introduce-go-linters
branch
from
581f946 to
6cf8d2b
Compare
Signed-off-by: Philipp Hinteregger <[email protected]>
|
at the moment, many error checks are replaced by _`s ... I would prefer to implement proper error handling instead of this, as it makes sense in many cases ... |
RealAnna
reviewed
Nov 22, 2022
RealAnna
reviewed
Nov 22, 2022
RealAnna
reviewed
Nov 22, 2022
RealAnna
reviewed
Nov 22, 2022
Signed-off-by: Philipp Hinteregger <[email protected]>
bacherfl
reviewed
Nov 23, 2022
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
approved these changes
Nov 23, 2022
mowies
reviewed
Nov 23, 2022
| - name: "scheduler" | ||
| folder: "scheduler/" | ||
| steps: | ||
| - name: Check out code into the Go module directory |
There was a problem hiding this comment.
this name is maybe a bit misleading. what go module are we meaning here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes
Follow up tasks
Signed-off-by: Philipp Hinteregger [email protected]