chore(lifecycle-operator): remove unused FailAction parameter from KeptnEvaluation

[odubajDT]

Fixes: #3131

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (ce57993) to head (1f90091).
Report is 91 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3138      +/-   ##
==========================================
+ Coverage   85.75%   86.81%   +1.06%     
==========================================
  Files         162      162              
  Lines       10351     8590    -1761     
==========================================
- Hits         8876     7457    -1419     
+ Misses       1186      842     -344     
- Partials      289      291       +2     

Files	Coverage Δ
...or/apis/lifecycle/v1beta1/keptnevaluation_types.go	96.82% <ø> (-0.48%)	⬇️

... and 138 files with indirect coverage changes

Flag	Coverage Δ
certificate-operator	69.23% <ø> (+1.80%)	⬆️
component-tests	56.55% <ø> (+0.55%)	⬆️
keptn-lifecycle-operator	?
lifecycle-operator	86.45% <ø> (+1.16%)	⬆️
metrics-operator	88.32% <ø> (+0.68%)	⬆️
scheduler	34.74% <ø> (-1.79%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[prakrit55]

hey @odubajDT, I think the failAction: got removed from here in v1alpha1 in helm templates and in the .helm-tests/l*/results

lifecycle-toolkit/lifecycle-operator/chart/templates/keptnevaluation-crd.yaml

Line 74 in a35a629

appName:

lifecycle-toolkit/lifecycle-operator/config/crd/bases/lifecycle.keptn.sh_keptnevaluations.yaml

Line 74 in a35a629

failAction:

[odubajDT]

hey @odubajDT, I think the failAction: got removed from here in v1alpha1 in helm templates and in the .helm-tests/l*/results

lifecycle-toolkit/lifecycle-operator/chart/templates/keptnevaluation-crd.yaml

Line 74 in a35a629

appName:

lifecycle-toolkit/lifecycle-operator/config/crd/bases/lifecycle.keptn.sh_keptnevaluations.yaml

Line 74 in a35a629

failAction:

Good catch, thank you! Are you willing to make a fix and open a PR?

[prakrit55]

hey @odubajDT, I think the failAction: got removed from here in v1alpha1 in helm templates and in the .helm-tests/l*/results

lifecycle-toolkit/lifecycle-operator/chart/templates/keptnevaluation-crd.yaml

Line 74 in a35a629

appName:

lifecycle-toolkit/lifecycle-operator/config/crd/bases/lifecycle.keptn.sh_keptnevaluations.yaml

Line 74 in a35a629

failAction:

Good catch, thank you! Are you willing to make a fix and open a PR?

happy to do that 😀