Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused FailAction parameter from KeptnEvaluation #3131

Closed
Tracked by #218
odubajDT opened this issue Feb 27, 2024 · 2 comments · Fixed by #3138
Closed
Tracked by #218

Remove unused FailAction parameter from KeptnEvaluation #3131

odubajDT opened this issue Feb 27, 2024 · 2 comments · Fixed by #3138
Assignees
@odubajDT
Labels
chore Maintenance good first issue Good for newcomers lifecycle-operator

Comments

@odubajDT
Copy link
Contributor

Description

.spec.FailAction parameter of KeptnEvaluation is not used anywhere in the code and has no effect on the functionality. We should consider removing it.

https://github.com/keptn/lifecycle-toolkit/blob/main/lifecycle-operator/apis/lifecycle/v1beta1/keptnevaluation_types.go#L62
@odubajDT odubajDT added lifecycle-operator bug Something isn't working labels Feb 27, 2024
@odubajDT odubajDT changed the title Remove unused FailAction parameter from KeptnEvaluationDefinition Remove unused FailAction parameter from KeptnEvaluation Feb 27, 2024
@odubajDT odubajDT added chore Maintenance and removed bug Something isn't working labels Feb 27, 2024
@odubajDT odubajDT mentioned this issue Feb 27, 2024
Closed
@prakrit55
Copy link
Member

@odubajDT, I would like to do it

@odubajDT
Copy link
Contributor Author

@odubajDT, I would like to do it

Hi @prakrit55 as I can see you have an opened PR and an issue already assigned. Please try to finish it first. Afterwards I will gladly assign this issue to you if it's still free!

@odubajDT odubajDT added status: ready-for-refinement Issue is relevant for the next backlog refinment good first issue Good for newcomers and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels Feb 27, 2024
@odubajDT odubajDT self-assigned this Feb 28, 2024
@odubajDT odubajDT mentioned this issue Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odubajDT odubajDT

Labels
chore Maintenance good first issue Good for newcomers lifecycle-operator
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(lifecycle-operator): remove unused FailAction parameter from KeptnEvaluation
2 participants
@odubajDT @prakrit55