Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): update controller logic to support multiple metric values #2190

Merged

Conversation

rakshitgondwal
Copy link
Member

@rakshitgondwal rakshitgondwal commented Sep 27, 2023

Fixes #2083

Information

This PR modifies the metrics controller logic to support multiple metrics in its status field.
If a user has specified the metric.spec.range.storedResults field with n (n can be <= 255), the user will be able to see a slice of n number of metrics under metric.status.intervalResults.

Screenshots

Screenshot from 2024-01-10 23-22-06

Screenshot from 2024-01-10 23-22-33

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 89455c1
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6542695e713b190008c98fde
😎 Deploy Preview https://deploy-preview-2190--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7de5919) 85.66% compared to head (7ceb7a8) 85.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2190      +/-   ##
==========================================
- Coverage   85.66%   85.63%   -0.03%     
==========================================
  Files         160      160              
  Lines       10140    10161      +21     
==========================================
+ Hits         8686     8701      +15     
- Misses       1173     1176       +3     
- Partials      281      284       +3     
Files Coverage Δ
metrics-operator/controllers/metrics/controller.go 80.27% <90.90%> (+0.90%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.79% <ø> (+0.34%) ⬆️
lifecycle-operator 84.62% <ø> (ø)
metrics-operator 87.63% <90.90%> (-0.02%) ⬇️
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

github-actions bot commented Jan 1, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be
closed if no further activity occurs. Thank you for your contributions.

rakshitgondwal and others added 8 commits January 7, 2024 23:24
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
@rakshitgondwal rakshitgondwal marked this pull request as ready for review January 10, 2024 17:57
@rakshitgondwal rakshitgondwal requested a review from a team as a code owner January 10, 2024 17:57
@bacherfl
Copy link
Member

Thanks for making the adaptations @rakshitgondwal - I will go through the PR today and review it

Signed-off-by: Rakshit Gondwal <[email protected]>
@bacherfl
Copy link
Member

there seems to be a failing unit test - when this is fixed i think we can get this merged :)

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT
Copy link
Contributor

Thank you for contribution!

@odubajDT odubajDT merged commit 42b805c into keptn:main Jan 22, 2024
34 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
…etric values (keptn#2190)

Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the metrics controller to support multiple metric values
3 participants