-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics-operator): update controller logic to support multiple metric values #2190
feat(metrics-operator): update controller logic to support multiple metric values #2190
Conversation
Signed-off-by: Rakshit Gondwal <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
==========================================
- Coverage 85.66% 85.63% -0.03%
==========================================
Files 160 160
Lines 10140 10161 +21
==========================================
+ Hits 8686 8701 +15
- Misses 1173 1176 +3
- Partials 281 284 +3
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR has been automatically marked as stale because it has not had recent activity. It will be |
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Thanks for making the adaptations @rakshitgondwal - I will go through the PR today and review it |
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
there seems to be a failing unit test - when this is fixed i think we can get this merged :) |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Thank you for contribution! |
…etric values (keptn#2190) Signed-off-by: Rakshit Gondwal <[email protected]> Signed-off-by: Rakshit Gondwal <[email protected]> Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Fixes #2083
Information
This PR modifies the metrics controller logic to support multiple metrics in its
status
field.If a user has specified the
metric.spec.range.storedResults
field withn
(n can be <= 255), the user will be able to see a slice ofn
number of metrics undermetric.status.intervalResults
.Screenshots