Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the metrics controller to support multiple metric values #2083

Closed
Tracked by #1883
rakshitgondwal opened this issue Sep 12, 2023 · 3 comments · Fixed by #2190
Closed
Tracked by #1883

Modify the metrics controller to support multiple metric values #2083

rakshitgondwal opened this issue Sep 12, 2023 · 3 comments · Fixed by #2190
Assignees

Comments

@rakshitgondwal
Copy link
Member

Description

Once the new fields have been added to the KeptnMetric to support multiple metric values, we'll need to update the metrics-controller to support these new fields.

The metrics-controller would query the SLI provider in an interval of fetchIntervalSeconds and keep the last spec.range.storedResults amount of results. It basically acts as an LRU with a capacity of spec.range.storedResults.
The maximum amount should be tested and found as part of this ticket - a good value could be 255.

Later, we can modify the status field to have a status.results field that would contain a slice/array of a Result struct.
The Result struct can have the value, lastUpdated, err fields for a particular metric.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be
closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 11, 2023
@mowies
Copy link
Member

mowies commented Dec 11, 2023

@rakshitgondwal any updates? I see the PR is still in draft mode

@github-actions github-actions bot removed the stale label Dec 12, 2023
@rakshitgondwal
Copy link
Member Author

Got busy with other stuff, will continue working on this @mowies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants