Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cloud events support #1843

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Aug 6, 2023

This PR

  • adds an optional new entry in the KeptnConfig to configure the CE endpoint
  • adds a CloudEvent emitter
  • register by default both K8s and CE as destination of events

Parts of #1841

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 6ad244c
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64d345a15b07360008542634
😎 Deploy Preview https://deploy-preview-1843--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #1843 (2c9af46) into main (adf4621) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 81.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
+ Coverage   83.38%   83.41%   +0.03%     
==========================================
  Files         134      135       +1     
  Lines        8288     8346      +58     
==========================================
+ Hits         6911     6962      +51     
- Misses       1121     1127       +6     
- Partials      256      257       +1     
Files Changed Coverage Δ
...cycle-operator/controllers/common/config/config.go 69.23% <0.00%> (-30.77%) ⬇️
...fecycle-operator/controllers/common/eventsender.go 88.70% <87.71%> (-11.30%) ⬇️

... and 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
lifecycle-operator 84.88% <81.96%> (-0.05%) ⬇️
metrics-operator 82.92% <ø> (+0.02%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thisthat thisthat force-pushed the feat/expose-cloud-events branch 3 times, most recently from 343de41 to 2cce059 Compare August 8, 2023 11:59
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 8, 2023
@thisthat thisthat changed the title feat: add cloud events endpoint to config feat: add cloud events support Aug 8, 2023
@thisthat thisthat marked this pull request as ready for review August 9, 2023 05:32
@thisthat thisthat requested review from a team as code owners August 9, 2023 05:32
@thisthat thisthat force-pushed the feat/expose-cloud-events branch from 36c83cc to 6ad244c Compare August 9, 2023 07:51
Signed-off-by: Giovanni Liva <[email protected]>
@github-actions github-actions bot added the helm label Aug 9, 2023
Signed-off-by: Giovanni Liva <[email protected]>
odubajDT
odubajDT previously approved these changes Aug 9, 2023
Signed-off-by: Giovanni Liva <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@bacherfl bacherfl merged commit 5b47120 into keptn:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm lifecycle-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants