emit in goroutine

Signed-off-by: Giovanni Liva <[email protected]>
keptn · Aug 9, 2023 · 2c9af46 · 2c9af46
1 parent 80d1112
commit 2c9af46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lifecycle-operator/controllers/common/eventsender.go b/lifecycle-operator/controllers/common/eventsender.go
@@ -43,7 +43,7 @@ func (e *EventMultiplexer) register(emitter IEvent) {
 func (e *EventMultiplexer) Emit(phase apicommon.KeptnPhaseType, eventType string, reconcileObject client.Object, status string, message string, version string) {
 	for _, emitter := range e.emitters {
 		e.logger.Info(fmt.Sprintf("Emitting event using %T", emitter))
-		emitter.Emit(phase, eventType, reconcileObject, status, message, version)
+		go emitter.Emit(phase, eventType, reconcileObject, status, message, version)
 	}
 }
 

diff --git a/lifecycle-operator/controllers/common/eventsender_test.go b/lifecycle-operator/controllers/common/eventsender_test.go
@@ -184,7 +184,9 @@ func TestEventSender_Multiplexer_emit(t *testing.T) {
 	// fire a new event
 	msg := "my special message"
 	emitter.Emit(common.PhaseAppDeployment, "", nil, "", msg, "")
-	// assert we got one event each
+	// assert we got one event
+	// let's wait few seconds so the async emit takes place
+	<-time.After(3 * time.Second)
 	require.Equal(t, 2, len(emitter.emitters))
 	require.Equal(t, 1, len(em1.events))
 	require.Equal(t, 1, len(em2.events))