Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): refactor k8s Event sending mechanism #1687

Merged
merged 2 commits into from
Jul 6, 2023
Merged

chore(operator): refactor k8s Event sending mechanism #1687

merged 2 commits into from
Jul 6, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jul 6, 2023

Part of: #1683

Changes

  • introduces new component EventSender instead of a function that uses recorder and sends k8s Events
  • adapt code to use EventSender

Follow up

  • normalize k8s Events sent in the system according to the ticket description

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c7b81a9
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64a6a98eb061c90008b62877
😎 Deploy Preview https://deploy-preview-1687--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1687 (3454c41) into main (78ba574) will decrease coverage by 0.05%.
The diff coverage is 70.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   63.47%   63.43%   -0.05%     
==========================================
  Files         142      143       +1     
  Lines       10899    10903       +4     
==========================================
- Hits         6918     6916       -2     
- Misses       3719     3723       +4     
- Partials      262      264       +2     
Impacted Files Coverage Δ
operator/controllers/common/helperfunctions.go 98.52% <ø> (-0.09%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 55.71% <ø> (ø)
...trollers/lifecycle/keptntask/job_runner_builder.go 100.00% <ø> (ø)
...ollers/lifecycle/keptntaskdefinition/controller.go 80.43% <ø> (ø)
...controllers/lifecycle/keptntask/runtime_builder.go 70.44% <33.33%> (ø)
...rator/webhooks/pod_mutator/pod_mutating_webhook.go 74.30% <33.33%> (ø)
...rator/controllers/lifecycle/keptnapp/controller.go 64.10% <50.00%> (ø)
...ontrollers/lifecycle/keptnevaluation/controller.go 76.43% <50.00%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 74.16% <50.00%> (ø)
...ifecycle/keptntaskdefinition/reconcile_function.go 75.55% <50.00%> (ø)
... and 12 more
Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.86% <48.64%> (-0.41%) ⬇️
lifecycle-operator 84.50% <62.71%> (+0.01%) ⬆️
metrics-operator 82.26% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review July 6, 2023 12:02
@odubajDT odubajDT requested a review from a team as a code owner July 6, 2023 12:02
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odubajDT odubajDT merged commit 20839af into keptn:main Jul 6, 2023
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants