-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(operator): refactor k8s Event sending mechanism #1687
Conversation
Signed-off-by: odubajDT <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1687 +/- ##
==========================================
- Coverage 63.47% 63.43% -0.05%
==========================================
Files 142 143 +1
Lines 10899 10903 +4
==========================================
- Hits 6918 6916 -2
- Misses 3719 3723 +4
- Partials 262 264 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: odubajDT <[email protected]> Signed-off-by: Nitishupkr <[email protected]>
Part of: #1683
Changes
EventSender
instead of a function that uses recorder and sends k8s EventsEventSender
Follow up