Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle Operator :: Emit K8s Events for all phases #1683

Closed
3 tasks done
thisthat opened this issue Jul 5, 2023 · 0 comments · Fixed by #1692
Closed
3 tasks done

Lifecycle Operator :: Emit K8s Events for all phases #1683

thisthat opened this issue Jul 5, 2023 · 0 comments · Fixed by #1692
Assignees
Milestone

Comments

@thisthat
Copy link
Member

thisthat commented Jul 5, 2023

Goal

Make sure that for each phase we emit events consistently.

Details

For each phase, we emit K8s events that have no consistent value for the reason field.
We should take the opportunity to refactor the codebase to align event creation so it would be easier to move to a different standard or multiplexing the events to multiple channels. for example, publish a K8s event together with a CloudEvent and a Kafka message.

Acceptance Criteria

  • When an event is fired, the reason field has the following format: ${phaseName}${status}, where ${status} is one of the following: Started,Finished,Failed
  • The code to emit events is centralized making it easier to extend to other than just K8s events

DoD

  • Events have a consistent reason field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants