Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): introduce validating webhook for KeptnConfig #1100

Closed
wants to merge 11 commits into from

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Mar 23, 2023

Signed-off-by: Giovanni Liva [email protected]

Part of #1095

Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 714ad82
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/641c53d8d74ce000084e94e8
😎 Deploy Preview https://deploy-preview-1100--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1100 (55301d2) into main (8a7a6af) will increase coverage by 0.37%.
The diff coverage is 61.53%.

❗ Current head 55301d2 differs from pull request most recent head 7328263. Consider uploading reports for the commit 7328263 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
+ Coverage   58.98%   59.36%   +0.37%     
==========================================
  Files         126      128       +2     
  Lines       10007    10100      +93     
==========================================
+ Hits         5903     5996      +93     
+ Misses       3888     3886       -2     
- Partials      216      218       +2     
Impacted Files Coverage Δ
...rator/apis/options/v1alpha1/keptnconfig_webhook.go 52.38% <52.38%> (ø)
...ator/controllers/options/keptnconfig_controller.go 84.90% <100.00%> (+2.40%) ⬆️

... and 8 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.97% <ø> (-0.73%) ⬇️
lifecycle-operator 78.45% <61.53%> (+0.04%) ⬆️
metrics-operator 77.35% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat marked this pull request as ready for review March 23, 2023 16:01
@bacherfl
Copy link
Member

let's fix the linting errors, the rest looks good to me

thisthat and others added 3 commits March 24, 2023 10:44
Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat marked this pull request as draft March 24, 2023 21:03
Signed-off-by: Giovanni Liva <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat thisthat closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants