Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing the KeptnConfig implementation #1095

Closed
3 of 5 tasks
thisthat opened this issue Mar 23, 2023 · 3 comments · Fixed by #1348
Closed
3 of 5 tasks

Polishing the KeptnConfig implementation #1095

thisthat opened this issue Mar 23, 2023 · 3 comments · Fixed by #1348
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@thisthat
Copy link
Member

thisthat commented Mar 23, 2023

Goal

Clean up the implementation of KeptnConfig

Technical Details

In the manifests, we are configuring a default URL for the collector but it is ignored since we prefer the value coming from a KeptnConfig. We should make use of the env var to initialize a defaultKeptnConfig until a CRD is reconciled.
Given that we reconcile it, a validation webhook with the following behavior:

  • if there is already an existing KeptnConfig CRD
    • if they have the same name, succeed
    • otherwise fail
  • otherwise succeed

The RBAC should also be cleaned up:

  • RBAC should grant read-only permissions on both, spec and status
  • no finalizer is needed

Acceptance Criteria

  • Use env vars as defaults
  • Introduce a validating webhook
  • RBAC is cleaned up

DoD

  • Tests for the validating webhook
  • Documentation update
@odubajDT
Copy link
Contributor

@thisthat is this ticket done, or is something missing ?

@thisthat
Copy link
Member Author

thisthat commented Apr 26, 2023

Hey @odubajDT, the documentation is not yet done. Maybe we can close it with #1239

@odubajDT
Copy link
Contributor

odubajDT commented May 3, 2023

The team agreed that the validating webhook was not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants