fix(operator): fix calculation of deployment interval metrics #822

bacherfl · 2023-02-13T09:21:49Z

Closes #807

This PR fixes the calculation of the deployment interval metrics.

When calculating these metrics for AppVersions, which support multiple revisions for the same version since the last release, the earliest revision of a KeptnAppVersion's predecessor is being used as a reference.

Signed-off-by: Florian Bacher [email protected]

Signed-off-by: Florian Bacher <[email protected]>

codecov · 2023-02-13T09:26:27Z

Codecov Report

Merging #822 (248bfd3) into main (b5c5801) will increase coverage by 0.80%.
The diff coverage is 84.37%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
+ Coverage   57.75%   58.55%   +0.80%     
==========================================
  Files          91       97       +6     
  Lines        7243     7552     +309     
==========================================
+ Hits         4183     4422     +239     
- Misses       2891     2938      +47     
- Partials      169      192      +23

Impacted Files	Coverage Δ
operator/controllers/common/metrics.go	`79.41% <79.16%> (-5.08%)`	⬇️
...r/apis/lifecycle/v1alpha2/keptnappversion_types.go	`97.59% <100.00%> (ø)`
.../lifecycle/v1alpha2/keptnworkloadinstance_types.go	`95.32% <100.00%> (ø)`
operator/controllers/common/otel_utils.go	`70.64% <100.00%> (+4.46%)`	⬆️
operator/controllers/common/providers/provider.go	`80.00% <0.00%> (-20.00%)`	⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go	`81.16% <0.00%> (-1.64%)`	⬇️
operator/controllers/common/providers/common.go	`100.00% <0.00%> (ø)`
operator/controllers/common/providers/dynatrace.go
...perator/controllers/common/providers/prometheus.go
... and 15 more

Flag	Coverage Δ
component-tests	`41.52% <0.00%> (-6.89%)`	⬇️
keptn-lifecycle-operator	`54.67% <84.37%> (+1.07%)`	⬆️
klt-cert-manager	`67.50% <ø> (ø)`
scheduler	`21.17% <ø> (ø)`