Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics keptn.deployment.deploymentinterval and keptn.app.deploymentinterval not calculated #807

Closed
bacherfl opened this issue Feb 9, 2023 · 0 comments · Fixed by #822
Closed
Assignees
Labels
bug Something isn't working

Comments

@bacherfl
Copy link
Member

bacherfl commented Feb 9, 2023

Detected in current main branch

Currently, the two metrics mentioned in the title are not exported, most likely due to the change of the naming scheme which was introduced for the restartable applications feature - due to these changes the lookup of the predecessor of a KeptnAppVersion does not yield any result, as it does not consider the revision in the name lookup:

err := client.Get(ctx, types.NamespacedName{Name: fmt.Sprintf("%s-%s", reconcileObject.GetParentName(), reconcileObject.GetPreviousVersion()), Namespace: reconcileObject.GetNamespace()}, previousObject)

Also, since this function already has the complete list of KeptnAppVersions/WorkloadInstances we might be able to get rid of the GET request to the kubernetes API when retrieving the predecessor of the respective AppVersion/WorkloadInstance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant