-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lifecycle-operator): introduce v1beta1 lifecycle API #2640
Conversation
Signed-off-by: Griffin <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lifecycle-operator/apis/lifecycle/v1alpha3/keptnappversion_types.go
Outdated
Show resolved
Hide resolved
Please revert the changes made in the /test folder, as this change should have no effect on the tests, as v1beta1 is still not used in the controller logic |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
+ Coverage 85.47% 86.59% +1.11%
==========================================
Files 155 168 +13
Lines 10178 11176 +998
==========================================
+ Hits 8700 9678 +978
- Misses 1199 1217 +18
- Partials 279 281 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Griffin <[email protected]>
test/integration/simple-deployment-container-annotation/01-assert.yaml
Outdated
Show resolved
Hide resolved
test/integration/simple-deployment-recursive-task/01-assert.yaml
Outdated
Show resolved
Hide resolved
lifecycle-operator/apis/lifecycle/v1beta1/keptnapp_conversion.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/apis/lifecycle/v1alpha3/keptntaskdefinition_types.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
lifecycle-operator/apis/lifecycle/v1beta1/keptntaskdefinition_types.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Griffin <[email protected]>
@prakrit55 I think we can remove the I would suggest to create the new test in a directory called
|
Hi @prakrit55 any news on that one? If you need support, please feel free to reach out |
Hey @bacherfl, I got stuck somehow, because of the university exams I m not able to push the changes. Would u mind if I make the changes tomorrow ? |
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
configured assert Signed-off-by: Prakriti Mandal <[email protected]>
added tests Signed-off-by: Prakriti Mandal <[email protected]>
configured assert Signed-off-by: Prakriti Mandal <[email protected]>
added test Signed-off-by: Prakriti Mandal <[email protected]>
fixed lint Signed-off-by: Prakriti Mandal <[email protected]>
fixed lint Signed-off-by: Prakriti Mandal <[email protected]>
fixed lint Signed-off-by: Prakriti Mandal <[email protected]>
fixed lint Signed-off-by: Prakriti Mandal <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
Description
Fixes #2573
How to test
Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.
Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide
Summary
Please include a short summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview