Make Dynatrace DQL provider oAuth URL configurable

[bacherfl]

Description

Currently, the oAuth URL for the DQL provider is hardcoded here:

lifecycle-toolkit/metrics-operator/controllers/common/providers/dynatrace/client/common.go

Line 15 in 88d693a

defaultAuthURL = "https://dev.token.internal.dynatracelabs.com/sso/oauth2/token"

The goal of this ticket is to make this configurable by adding a key to the secret containing the client credentials that are used to authenticate the client at the oAuth URL

The current secret could be a good place where to store this information.

DoD

• Feature implemented
• Unit tests

[Sourav-Kumar-Panda]

Can i work on this?

[RealAnna]

Hi @Sourav-Kumar-Panda sure you can! Let us know if anything in the ticket is unclear 🚀

[mowies]

any updates on this @Sourav-Kumar-Panda ?

[github-actions]

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

[prakrit55]

Hey @mowies, I wd like fix this.

[mowies]

Great! Thank you!

[prakrit55]

hey @mowies, I looked into it and so abt it do I need to create a field function for another key in secret which defines the AuthUrl which the user can configure ??

[bacherfl]

Hi @prakrit55 ! In the KeptnMetricProviderSpec we only allow to refer to one key within a secret. To not break that interface, I would suggest to change the expected format from a value containing the api token to a json encoded object containing a token and an authURL field. So this section here needs to be adapted:

lifecycle-toolkit/metrics-operator/controllers/common/providers/dynatrace/common.go

Line 36 in 9ee4583

token := string(dtCredsSecret.Data[provider.Spec.SecretKeyRef.Key])

Please let me know if there is anything unclear

[prakrit55]

hey @bacherfl, one reconfirmation, so the authUrl should contain the token in its field, which need to be passed ??

[bacherfl]

Hi @prakrit55 , there should be a new field called authUrl , in addition to the token, that was previously defined in the secret. So for example, the content of the secret should be something like this:

{"authURL": "my-auth-url", "token":"my-token"}

[odubajDT]

Hi @prakrit55, do you plan to work on this issue? I see you are working also on another one #2640

Thanks!

[prakrit55]

Hi @prakrit55, do you plan to work on this issue? I see you are working also on another one #2640

Thanks!

hey @odubajDT, after the former is done, I'm willing to continue it or if its an immediate requirement I will pull off a pr today itself, it wd be no hurdle for me

[odubajDT]

Hi @prakrit55, do you plan to work on this issue? I see you are working also on another one #2640
Thanks!

hey @odubajDT, after the former is done, I'm willing to continue it or if its an immediate requirement I will pull off a pr today itself, it wd be no hurdle for me

Thanks for the update, we still have some time.

[github-actions]

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

[rakshitgondwal]

Reopening this as an open PR is already linked to this issue.