Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce v1beta1 lifecycle API #2573

Closed
8 tasks
Tracked by #1394 ...
bacherfl opened this issue Nov 27, 2023 · 5 comments · Fixed by #2640
Closed
8 tasks
Tracked by #1394 ...

Introduce v1beta1 lifecycle API #2573

bacherfl opened this issue Nov 27, 2023 · 5 comments · Fixed by #2640
Assignees
Labels
Milestone

Comments

@bacherfl
Copy link
Member

bacherfl commented Nov 27, 2023

Goal

The goal of this issue is to move the CRDs from v1alpha3/v1alpha4 the new API version v1beta1.

Details

The v1beta1 version should have the following, which should have the same definition as in v1alpha3/v1alpha4, those are:

  • KeptnApp
  • KeptnAppCreationRequest
  • KeptnAppVersion
  • KeptnEvaluation
  • KeptnTask
  • KeptnTaskDefinition
  • KeptnWorkload
  • KeptnWorkloadVersion

The following v1alpha3 CRDs do not need to be moved to v1beta:

  • KeptnEvaluationProvider
  • KeptnWorkloadInstance

Acceptance Criteria

  • new version v1beta1 contains the mentioned CRDs
  • the new CRDs can be applied to the cluster where the lifecycle-operator is installed
  • CRDs are part of helm charts
  • CRD documentation is re-generated

DoD

  • added v1beta1 version with the mentioned CRDs
  • integrations test that the CRDs can be applied to the cluster
  • README badge contains v1beta1
  • upgrade using helm charts is possible

References

Link to the PoC: #2570

@mowies mowies added status: ready-for-refinement Issue is relevant for the next backlog refinment and removed status: needs-discussion labels Nov 28, 2023
@mowies mowies added this to the 0.10 milestone Nov 28, 2023
@mowies mowies removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Nov 29, 2023
@mowies mowies moved this to 🎟️ Refined in Keptn Lifecycle Toolkit Nov 29, 2023
@prakrit55
Copy link
Member

hey @bacherfl, @mowies let me commit it 🤗

@prakrit55
Copy link
Member

should I create the create common for v1beta1 too ??

@mowies
Copy link
Member

mowies commented Dec 4, 2023

Sorry, @prakrit55 , but this is pretty important since many other tickets depend on this. That's why one of the core maintainers will implement it. Please feel free to take a different ticket :)

@prakrit55
Copy link
Member

Sorry, @prakrit55 , but this is pretty important since many other tickets depend on this. That's why one of the core maintainers will implement it. Please feel free to take a different ticket :)

Hey @mowies, I think with a little acquaintance, I could settle it. I have seen the v1beta1 introduced in metrics-operator, so I already started it. If it still needs the maintainers then its okay from meee 🙂

@mowies
Copy link
Member

mowies commented Dec 4, 2023

Ok if you feel like you're up for it, then go ahead! 😄
If needed, somebody else can take over from you anyways :)
The metrics API change is definitely the best bet to see how it's all done 👍🏼

@mowies mowies moved this from 🎟️ Refined to 🏃 In progress in Keptn Lifecycle Toolkit Dec 4, 2023
@mowies mowies modified the milestones: 0.10, 0.11 Dec 6, 2023
@github-project-automation github-project-automation bot moved this from 🏃 In progress to ✅ Done in Keptn Lifecycle Toolkit Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants