Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update contribution guideline link in PR template #2003

Merged
merged 6 commits into from
Sep 26, 2023
Merged

docs: update contribution guideline link in PR template #2003

merged 6 commits into from
Sep 26, 2023

Conversation

SagarRawat24
Copy link
Contributor

@SagarRawat24 SagarRawat24 commented Sep 3, 2023 •
edited by mowies
Loading

Fixes #1952

@SagarRawat24 SagarRawat24 requested a review from a team as a code owner September 3, 2023 07:20
@github-actions github-actions bot added the ops label Sep 3, 2023
@netlify
Copy link

netlify bot commented Sep 3, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 10ac582
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64f433da822c0f0008a45c58
😎 Deploy Preview https://deploy-preview-2003--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mowies
mowies requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please link to the page links on our docs page instead of the source markdown files

@mowies mowies changed the title feat: correct link in pr-template.md #1952 docs: update contribution guideline link in PR template Sep 4, 2023
@SagarRawat24
Copy link
Contributor Author

hey @mowies you telling this docs/content/en/contribute/docs/contrib-guidelines-docs/_index.md instead of url browser link i just confirm that

@mowies
Copy link
Member

mowies commented Sep 4, 2023

yea. you should find the right things on the page in the contributing guide here: https://lifecycle.keptn.sh/contribute/
it could be that some parts are not live yet, then you'll find them under releases dropdown menu -> development

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thisthat
Copy link
Member

Thanks @SagarRawat24 for your contribution, merging the PR :shipit:

@thisthat thisthat merged commit 84ae464 into keptn:main Sep 26, 2023
14 checks passed
@keptn-bot keptn-bot mentioned this pull request Sep 26, 2023
Merged
RealAnna pushed a commit that referenced this pull request Sep 27, 2023
@SagarRawat24 @RealAnna
docs: update contribution guideline link in PR template (#2003)
a8c170e
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakshitgondwal rakshitgondwal rakshitgondwal left review comments

@mowies mowies mowies approved these changes

@thisthat thisthat thisthat approved these changes

Assignees
No one assigned
Labels
ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

correct xrefs in pr-template.md
4 participants
@SagarRawat24 @mowies @thisthat @rakshitgondwal