Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contribution guideline link in PR template #2003

Merged
merged 6 commits into from
Sep 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions .github/PULL_REQUEST_TEMPLATE/pr-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,15 @@ Please also provide information about any automatic tests that you added.
- [ ] My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
into multiple PRs)
- [ ] I used descriptive commit messages to help reviewers understand my thought process
- [ ] I signed off all my commits according to the Developer Certificate of Origin (DCO) (
see [Contribution Guide](https://github.com/keptn/lifecycle-toolkit/blob/main/CONTRIBUTING.md#submit-a-pull-request-))
- [ ] I signed off all my commits according to the Developer Certificate of Origin (DCO)
see [Contribution Guide](https://lifecycle.keptn.sh/contribute/docs/contribution-guidelines)
- [ ] My PR title is formatted according to the semantic PR conventions described in
the [Contribution Guide](https://github.com/keptn/lifecycle-toolkit/blob/main/CONTRIBUTING.md#submit-a-pull-request-)
the [Contribution Guide](https://lifecycle.keptn.sh/contribute/docs/contribution-guidelines)
- [ ] My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
- [ ] I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
- [ ] I have performed a self-review of my code
- [ ] I have made corresponding changes to the documentation (if needed)
- [ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test
runs)
- [ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
- [ ] New and existing unit and integration tests pass locally with my changes

<!-- DOCS SECTION -->
Expand All @@ -54,13 +53,12 @@ Fixes # (issue)
- [ ] My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
into multiple PRs)
- [ ] I used descriptive commit messages to help reviewers understand my thought process
- [ ] I signed off all my commits according to the Developer Certificate of Origin (DCO) (
see [Contribution Guide](https://github.com/keptn/lifecycle-toolkit/blob/main/docs/CONTRIBUTING.md#developer-certification-of-origin-dco))
- [ ] I signed off all my commits according to the Developer Certificate of Origin (DCO)(
see [Contribution Guide](https://lifecycle.keptn.sh/contribute/docs/contribution-guidelines))
- [ ] My PR title is formatted according to the semantic PR conventions described in
the [Contribution Guide](https://github.com/keptn/lifecycle-toolkit/blob/main/CONTRIBUTING.md#submit-a-pull-request-)
the [Contribution Guide](https://lifecycle.keptn.sh/contribute/docs/contribution-guidelines)
- [ ] My content follows the style guidelines of this project (YAMLLint, markdown-lint)
- [ ] I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
- [ ] I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
from the Netlify deploy preview
- [ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test
runs)
- [ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)