-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add metrics-operator architecture #1151
Conversation
Signed-off-by: Rakshit Gondwal <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Rakshit Gondwal <[email protected]>
Line 11... github won't let me comment directly on that line, but I wonder if this is two components or three. Maybe say, "...the following components" and avoid the issue? |
docs/content/en/docs/concepts/architecture/components/metrics-operator/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/metrics-operator/_index.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/content/en/docs/concepts/architecture/components/metrics-operator/_index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <[email protected]>
docs/content/en/docs/concepts/architecture/components/metrics-operator/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/metrics-operator/_index.md
Outdated
Show resolved
Hide resolved
Thanks @rakshitgondwal for incorporating the changes for the description of the metrics! I found two minor nitpicks, but content wise the PR looks good |
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Due to the use of |
docs/content/en/docs/concepts/architecture/components/metrics-operator/_index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thank you for the merge! |
Fixes #1049
I have made the following changes in this PR:
metrics-operator
,lifecycle-operator
,KLT scheduler
in three different folders by modifyingarchitecture/components/_index.md