feat(operator): polish KeptnConfig and use Env Var for initial configuration
#1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
thisthat
changed the title
KeptnConfig for a default configuration instead of Env Var
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
thisthat
force-pushed
the
chore/1095/remove-env-var
branch
from
1ba03a9 to
fb5951a
Compare
RealAnna
reviewed
Mar 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
==========================================
+ Coverage 58.91% 59.29% +0.37%
==========================================
Files 126 126
Lines 10007 10072 +65
==========================================
+ Hits 5896 5972 +76
+ Misses 3893 3881 -12
- Partials 218 219 +1
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Giovanni Liva <[email protected]>
github-actions
bot
added
the
documentation
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
thisthat
changed the title
KeptnConfig for a default configuration instead of Env VarKeptnConfigand use Env Var for initial configuration
Signed-off-by: Giovanni Liva <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
changed the title
KeptnConfigand use Env Var for initial configurationKeptnConfig and use Env Var for initial configuration
odubajDT
approved these changes
Mar 27, 2023
bacherfl
approved these changes
Mar 27, 2023
Merged
mowies
reviewed
Mar 27, 2023
| OTelCollectorUrl string `json:"OTelCollectorUrl,omitempty"` | ||
| // KeptnAppCreationRequestTimeout is used to set the interval in which automatic app discovery | ||
| // searches for workload to put into the same auto-generated KeptnApp | ||
| // +kubebuilder:default:=30 | ||
| KeptnAppCreationRequestTimeout uint `json:"keptnAppCreationRequestTimeout,omitempty"` | ||
| // +optional | ||
| KeptnAppCreationRequestTimeoutSeconds uint `json:"keptnAppCreationRequestTimeoutSeconds,omitempty"` |
There was a problem hiding this comment.
pls also change the docs string when you change the variable name here.
There was a problem hiding this comment.
do you mean something different than this?
https://github.com/keptn/lifecycle-toolkit/pull/1097/files#diff-7ab58e37e6f4412bbcc3d577c257684bae6e4bd7629ea0b57d38d996ad5119fcL66
aepfli
pushed a commit
to aepfli/lifecycle-toolkit
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
KeptnConfigPart of #1095