Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(operator): adjust docs comment #1126

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

thisthat
Copy link
Member

No description provided.

Signed-off-by: Giovanni Liva <[email protected]>
@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 820b016
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/642143094a0c98000877926a
😎 Deploy Preview https://deploy-preview-1126--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/options/v1alpha1
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mowies mowies changed the title chore(operator): adjust comment docs(operator): adjust docs comment Mar 27, 2023
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat requested a review from StackScribe as a code owner March 27, 2023 07:17
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1126 (820b016) into main (559acee) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
+ Coverage   59.05%   59.08%   +0.02%     
==========================================
  Files         126      126              
  Lines       10023    10023              
==========================================
+ Hits         5919     5922       +3     
+ Misses       3888     3886       -2     
+ Partials      216      215       -1     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 60.25% <ø> (-0.36%) ⬇️
lifecycle-operator 78.52% <ø> (ø)
metrics-operator 77.35% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 4078fad into keptn:main Mar 28, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 28, 2023
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants