Skip to content

Commit

Permalink
feat: improve naming (#961)
Browse files Browse the repository at this point in the history
Co-authored-by: odubajDT <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: realanna <[email protected]>
  • Loading branch information
4 people authored Mar 3, 2023
1 parent ef35387 commit bd49357
Show file tree
Hide file tree
Showing 87 changed files with 619 additions and 915 deletions.
2 changes: 1 addition & 1 deletion .github/.kubescape/exceptions.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"designatorType": "Attributes",
"attributes": {
"kind": "ServiceAccount",
"name": "klc-controller-manager"
"name": "lifecycle-operator"
}
}
],
Expand Down
18 changes: 9 additions & 9 deletions .github/actions/deploy-klt-on-cluster/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,23 +62,23 @@ runs:
shell: bash
run: |
echo "Installing KLT using manifests"
sed -i 's/imagePullPolicy: Always/imagePullPolicy: Never/g' ~/download/artifacts/keptn-lifecycle-operator-manifest-test/release.yaml
sed -i 's/ghcr.keptn.sh\/keptn\/functions-runtime:.*/localhost:5000\/keptn\/functions-runtime:${{ inputs.functions_runtime_tag }}/g' ~/download/artifacts/keptn-lifecycle-operator-manifest-test/release.yaml
sed -i 's/imagePullPolicy: Always/imagePullPolicy: Never/g' ~/download/artifacts/lifecycle-operator-manifest-test/release.yaml
sed -i 's/ghcr.keptn.sh\/keptn\/functions-runtime:.*/localhost:5000\/keptn\/functions-runtime:${{ inputs.functions_runtime_tag }}/g' ~/download/artifacts/lifecycle-operator-manifest-test/release.yaml
kubectl create namespace keptn-lifecycle-toolkit-system
kubectl apply -f ~/download/artifacts/keptn-lifecycle-operator-manifest-test
kubectl apply -f ~/download/artifacts/lifecycle-operator-manifest-test
sed -i 's/imagePullPolicy: Always/imagePullPolicy: Never/g' ~/download/artifacts/klt-cert-manager-manifest-test/release.yaml
kubectl apply -f ~/download/artifacts/klt-cert-manager-manifest-test
kubectl rollout status deployment klt-cert-manager -n keptn-lifecycle-toolkit-system -w
sed -i 's/imagePullPolicy: Always/imagePullPolicy: Never/g' ~/download/artifacts/certificate-operator-manifest-test/release.yaml
kubectl apply -f ~/download/artifacts/certificate-operator-manifest-test
kubectl rollout status deployment certificate-operator -n keptn-lifecycle-toolkit-system -w
sed -i 's/imagePullPolicy: Always/imagePullPolicy: Never/g' ~/download/artifacts/metrics-operator-manifest-test/release.yaml
kubectl apply -f ~/download/artifacts/metrics-operator-manifest-test
kubectl rollout status deployment metrics-operator-controller -n keptn-lifecycle-toolkit-system -w
kubectl rollout status deployment metrics-operator -n keptn-lifecycle-toolkit-system -w
sed -i 's/imagePullPolicy: Always/imagePullPolicy: Never/g' ~/download/artifacts/scheduler-manifest-test/release.yaml
kubectl apply -f ~/download/artifacts/scheduler-manifest-test
kubectl rollout status deployment keptn-scheduler -n keptn-lifecycle-toolkit-system -w
kubectl rollout status deployment klc-controller-manager -n keptn-lifecycle-toolkit-system -w
kubectl rollout status deployment scheduler -n keptn-lifecycle-toolkit-system -w
kubectl rollout status deployment lifecycle-operator -n keptn-lifecycle-toolkit-system -w
- name: Install lifecycle-toolkit with helm
if: ${{ inputs.helm-install == 'true' }}
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/CI.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ jobs:
strategy:
matrix:
config:
- name: "keptn-lifecycle-operator"
- name: "lifecycle-operator"
folder: "operator/"
- name: "metrics-operator"
folder: "metrics-operator/"
- name: "scheduler"
folder: "scheduler/"
- name: "klt-cert-manager"
- name: "certificate-operator"
folder: "klt-cert-manager/"
steps:
- name: Check out code
Expand Down Expand Up @@ -111,15 +111,15 @@ jobs:
strategy:
matrix:
config:
- name: "keptn-lifecycle-operator"
- name: "lifecycle-operator"
folder: "operator/"
- name: "metrics-operator"
folder: "metrics-operator/"
- name: "scheduler"
folder: "scheduler/"
- name: "functions-runtime"
folder: "functions-runtime/"
- name: "klt-cert-manager"
- name: "certificate-operator"
folder: "klt-cert-manager/"
steps:
- name: Check out code
Expand Down Expand Up @@ -163,7 +163,7 @@ jobs:
path: /tmp/${{ matrix.config.name }}-image.tar

- name: Install controller-gen
if: matrix.config.name == 'keptn-lifecycle-operator' || matrix.config.name == 'metrics-operator'
if: matrix.config.name == 'lifecycle-operator' || matrix.config.name == 'metrics-operator'
working-directory: ./${{ matrix.config.folder }}
run: make controller-gen

Expand Down Expand Up @@ -226,15 +226,15 @@ jobs:
strategy:
matrix:
config:
- name: "keptn-lifecycle-operator"
- name: "lifecycle-operator"
folder: "operator/"
- name: "metrics-operator"
folder: "metrics-operator/"
- name: "scheduler"
folder: "scheduler/"
- name: "functions-runtime"
folder: "functions-runtime/"
- name: "klt-cert-manager"
- name: "certificate-operator"
folder: "klt-cert-manager/"
permissions:
packages: write # Needed for pushing images to the registry
Expand Down Expand Up @@ -280,7 +280,7 @@ jobs:
cache-to: type=gha,scope=${{ github.ref_name }}-${{ matrix.config.name }}

- name: Install controller-gen
if: matrix.config.name == 'keptn-lifecycle-operator' || matrix.config.name == 'klt-cert-manager' || matrix.config.name == 'metrics-operator'
if: matrix.config.name == 'lifecycle-operator' || matrix.config.name == 'certificate-operator' || matrix.config.name == 'metrics-operator'
working-directory: ./${{ matrix.config.folder }}
run: make controller-gen

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
config:
- name: "keptn-lifecycle-operator"
- name: "lifecycle-operator"
folder: "operator/"
- name: "scheduler"
folder: "scheduler/"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ jobs:
fail-fast: false
matrix:
config:
- name: "keptn-lifecycle-operator"
- name: "lifecycle-operator"
folder: "operator/"
- name: "metrics-operator"
folder: "metrics-operator/"
- name: "scheduler"
folder: "scheduler/"
- name: "klt-cert-manager"
- name: "certificate-operator"
folder: "klt-cert-manager/"
steps:
- name: Check out code
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/helm-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ jobs:
strategy:
matrix:
config:
- name: "keptn-lifecycle-operator"
- name: "lifecycle-operator"
folder: "operator/"
- name: "metrics-operator"
folder: "metrics-operator/"
- name: "scheduler"
folder: "scheduler/"
- name: "functions-runtime"
folder: "functions-runtime/"
- name: "klt-cert-manager"
- name: "certificate-operator"
folder: "klt-cert-manager/"
steps:
- name: Check out code
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ jobs:
strategy:
matrix:
config:
- name: "keptn-lifecycle-operator"
- name: "lifecycle-operator"
folder: "operator/"
- name: "metrics-operator"
folder: "metrics-operator/"
- name: "scheduler"
folder: "scheduler/"
- name: "functions-runtime"
folder: "functions-runtime/"
- name: "klt-cert-manager"
- name: "certificate-operator"
folder: "klt-cert-manager/"
runs-on: ubuntu-22.04
permissions:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/security-scans.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,10 @@ jobs:
matrix:
image:
- "functions-runtime"
- "keptn-lifecycle-operator"
- "lifecycle-operator"
- "metrics-operator"
- "scheduler"
- "klt-cert-manager"
- "certificate-operator"
steps:
- name: Download images
id: download_images
Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/docs/concepts/metrics/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ variable `EXPOSE_KEPTN_METRICS` in the metrics-operator manifest needs to be set
is `true`. To access the metrics, use the following command:

```shell
kubectl port-forward deployment/metrics-operator-controller 9999 -n keptn-lifecycle-toolkit-system
kubectl port-forward deployment/metrics-operator 9999 -n keptn-lifecycle-toolkit-system
```

and access the metrics via your browser with:
Expand Down
4 changes: 2 additions & 2 deletions docs/content/en/docs/snippets/tasks/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ In version 0.6.0 and later, you can install the Lifecycle Toolkit using the curr

```shell
kubectl apply -f https://github.com/keptn/lifecycle-toolkit/releases/download/v0.5.0/manifest.yaml
kubectl wait --for=condition=Available deployment/klc-controller-manager -n keptn-lifecycle-toolkit-system --timeout=120s
kubectl wait --for=condition=Available deployment/lifecycle-operator -n keptn-lifecycle-toolkit-system --timeout=120s
```

<!---x-release-please-end-->
Expand All @@ -28,5 +28,5 @@ After that, you can install the Lifecycle Toolkit `<oldversion>` with:

```shell
kubectl apply -f https://github.com/keptn/lifecycle-toolkit/releases/download/<oldversion>/manifest.yaml
kubectl wait --for=condition=Available deployment/klc-controller-manager -n keptn-lifecycle-toolkit-system --timeout=120s
kubectl wait --for=condition=Available deployment/lifecycle-operator -n keptn-lifecycle-toolkit-system --timeout=120s
```
10 changes: 5 additions & 5 deletions examples/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ install: install-observability install-argo
@echo "Create Namespace and install Keptn-lifecycle-toolkit"
@echo "-----------------------------------"
kubectl apply -f https://github.com/keptn/lifecycle-toolkit/releases/download/v0.5.0/manifest.yaml #x-release-please-version
kubectl wait --for=condition=available deployment/klc-controller-manager -n keptn-lifecycle-toolkit-system --timeout=300s
kubectl wait --for=condition=available deployment/lifecycle-operator -n keptn-lifecycle-toolkit-system --timeout=300s

.PHONY: install-observability
install-observability:
Expand Down Expand Up @@ -75,7 +75,7 @@ restart-lifecycle-toolkit:
@echo "----------------------------------"
@echo "Restart Keptn Lifecycle Controller"
@echo "----------------------------------"
kubectl rollout restart deployment -n "$(TOOLKIT_NAMESPACE)" klc-controller-manager
kubectl rollout status deployment -n "$(TOOLKIT_NAMESPACE)" klc-controller-manager --watch
kubectl rollout restart deployment -n "$(TOOLKIT_NAMESPACE)" keptn-scheduler -n keptn-lifecycle-toolkit-system
kubectl rollout status deployment -n "$(TOOLKIT_NAMESPACE)" keptn-scheduler --watch
kubectl rollout restart deployment -n "$(TOOLKIT_NAMESPACE)" lifecycle-operator
kubectl rollout status deployment -n "$(TOOLKIT_NAMESPACE)" lifecycle-operator --watch
kubectl rollout restart deployment -n "$(TOOLKIT_NAMESPACE)" scheduler -n keptn-lifecycle-toolkit-system
kubectl rollout status deployment -n "$(TOOLKIT_NAMESPACE)" scheduler --watch
6 changes: 3 additions & 3 deletions examples/support/observability/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ in the `config` directory:
kubectl apply -f config/otel-collector.yaml -n keptn-lifecycle-toolkit-system
```

Also, please ensure that the `OTEL_COLLECTOR_URL` env vars of both the `klc-controller-manager`,
Also, please ensure that the `OTEL_COLLECTOR_URL` env vars of both the `lifecycle-operator`,
as well as the `keptn-scheduler` deployments are set appropriately.
By default, they are set to `otel-collector:4317`, which should be the correct value for this tutorial.

Expand All @@ -75,11 +75,11 @@ can edit the Collector ConfigMap with the following command:
kubectl edit configmap otel-collector-conf -n keptn-lifecycle-toolkit-system
```

When the `otel-collector` pod is up and running, restart the `keptn-scheduler` and `klc-controller-manager` so they can
When the `otel-collector` pod is up and running, restart the `keptn-scheduler` and `lifecycle-operator` so they can
pick up the new configuration.

```shell
kubectl rollout restart deployment -n keptn-lifecycle-toolkit-system keptn-scheduler klc-controller-manager
kubectl rollout restart deployment -n keptn-lifecycle-toolkit-system keptn-scheduler lifecycle-operator
```

## Seeing the OpenTelemetry Collector in action
Expand Down
2 changes: 1 addition & 1 deletion examples/support/observability/config/otel-collector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ data:
- job_name: 'otel-collector'
scrape_interval: 5s
static_configs:
- targets: ['klc-controller-manager-metrics-service:2222']
- targets: ['lifecycle-operator-metrics-service:2222']
processors:
extensions:
health_check: {}
Expand Down
Loading

0 comments on commit bd49357

Please sign in to comment.