Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve naming #961

Merged
merged 33 commits into from
Mar 3, 2023
Merged

feat: improve naming #961

merged 33 commits into from
Mar 3, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Mar 2, 2023

Fixes #960

BEGIN_COMMIT_OVERRIDE

feat: improve naming and use new repository

BREAKING CHANGE: The different components of KLT have been renamed and use a new container image repository. For more information, please look at #960

END_COMMIT_OVERRIDE

Signed-off-by: Giovanni Liva <[email protected]>
@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit e1e27c1
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6400c251064eac0008129ae4
😎 Deploy Preview https://deploy-preview-961--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #961 (1e90510) into main (82488ec) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
+ Coverage   57.45%   57.50%   +0.04%     
==========================================
  Files         119      119              
  Lines        9913     9913              
==========================================
+ Hits         5696     5700       +4     
+ Misses       4018     4015       -3     
+ Partials      199      198       -1     
Impacted Files Coverage Δ
operator/controllers/common/otel_utils.go 70.64% <100.00%> (ø)
...lers/lifecycle/keptnworkloadinstance/controller.go 82.95% <0.00%> (+1.79%) ⬆️
Flag Coverage Δ
certificate-operator 64.15% <ø> (?)
component-tests 50.99% <0.00%> (+0.82%) ⬆️
klt-cert-manager ?
lifecycle-operator 53.63% <100.00%> (?)
metrics-operator 62.95% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

thisthat added 3 commits March 2, 2023 14:42
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
@odubajDT odubajDT force-pushed the feat/960/improve-names branch from c9a0837 to c290cd0 Compare March 2, 2023 15:59
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT force-pushed the feat/960/improve-names branch from c290cd0 to 707ff46 Compare March 3, 2023 06:01
Signed-off-by: odubajDT <[email protected]>
odubajDT and others added 19 commits March 3, 2023 08:11
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
RealAnna added 7 commits March 3, 2023 11:51
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
@RealAnna RealAnna force-pushed the feat/960/improve-names branch from 8443c2f to 9b79614 Compare March 3, 2023 10:52
Signed-off-by: realanna <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna marked this pull request as ready for review March 3, 2023 10:56
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME

@thisthat thisthat merged commit bd49357 into keptn:main Mar 3, 2023
@thisthat thisthat deleted the feat/960/improve-names branch March 3, 2023 11:10
@keptn-bot keptn-bot mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve naming of the different components
4 participants