Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

#192 Allow to skip ssl verification #193

Merged

Conversation

agrimmer
Copy link
Collaborator

Closes #192

pkg/lib/configuration.go Outdated Show resolved Hide resolved
pkg/lib/configuration.go Outdated Show resolved Hide resolved
pkg/lib/configuration.go Outdated Show resolved Hide resolved
pkg/lib/configuration.go Outdated Show resolved Hide resolved
pkg/lib/configuration.go Outdated Show resolved Hide resolved
pkg/lib/configuration.go Show resolved Hide resolved
pkg/lib/configuration.go Show resolved Hide resolved
pkg/lib/configuration.go Outdated Show resolved Hide resolved
@agrimmer agrimmer force-pushed the feature/192/allow-skip-ssl-verification branch from 9ed677f to 917d858 Compare September 23, 2020 10:14
Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this looks fine, please address the changes for the README file

Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christian-kreuzberger-dtx christian-kreuzberger-dtx merged commit 2a8381f into master Sep 25, 2020
@christian-kreuzberger-dtx christian-kreuzberger-dtx deleted the feature/192/allow-skip-ssl-verification branch September 25, 2020 11:25
jetzlstorfer pushed a commit that referenced this pull request Jan 28, 2021
* #192 Allow to skip the ssl verification

* #192 Add docu

* #192 Address review dog comments

* #192 Address review

Signed-off-by: jetzlstorfer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a feature flag for disabling SSL verification
2 participants