This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
#192 Allow to skip ssl verification #193
Merged
christian-kreuzberger-dtx
merged 4 commits into
master
from
feature/192/allow-skip-ssl-verification
Sep 25, 2020
Merged
#192 Allow to skip ssl verification #193
christian-kreuzberger-dtx
merged 4 commits into
master
from
feature/192/allow-skip-ssl-verification
Sep 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrimmer
force-pushed
the
feature/192/allow-skip-ssl-verification
branch
from
September 23, 2020 10:14
9ed677f
to
917d858
Compare
christian-kreuzberger-dtx
suggested changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally this looks fine, please address the changes for the README file
christian-kreuzberger-dtx
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
christian-kreuzberger-dtx
deleted the
feature/192/allow-skip-ssl-verification
branch
September 25, 2020 11:25
jetzlstorfer
pushed a commit
that referenced
this pull request
Jan 28, 2021
* #192 Allow to skip the ssl verification * #192 Add docu * #192 Address review dog comments * #192 Address review Signed-off-by: jetzlstorfer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192