#192 Address review dog comments

pkg/lib/auto_tags.go

@@ -7,7 +7,7 @@ import (
 
 // EnsureDTTaggingRulesAreSetUp ensures that the tagging rules are set up
 func (dt *DynatraceHelper) EnsureDTTaggingRulesAreSetUp() {
-	if !GetTaggingRulesConfig() {
+	if !IsTaggingRulesGenerationEnabled() {
 		return
 	}
 

pkg/lib/configuration.go

@@ -5,26 +5,32 @@ import (
 	"strconv"
 )
 
-func GetTaggingRulesConfig() bool {
+// IsTaggingRulesGenerationEnabled returns whether tagging rules should be generated when configuring the monitoring
+func IsTaggingRulesGenerationEnabled() bool {
 	return readEnvAsBool("GENERATE_TAGGING_RULES", false)
 }
 
-func GetProblemNotificationsConfig() bool {
+// IsProblemNotificationsGenerationEnabled returns whether problem notifications should be generated when configuring the monitoring
+func IsProblemNotificationsGenerationEnabled() bool {
 	return readEnvAsBool("GENERATE_PROBLEM_NOTIFICATIONS", false)
 }
 
-func GetManagementZonesConfig() bool {
+// IsManagementZonesGenerationEnabled returns whether management zones should be generated when configuring the monitoring
+func IsManagementZonesGenerationEnabled() bool {
 	return readEnvAsBool("GENERATE_MANAGEMENT_ZONES", false)
 }
 
-func GetGenerateDashboardsConfig() bool {
+// IsDashboardsGenerationEnabled returns whether dashboards should be generated when configuring the monitoring
+func IsDashboardsGenerationEnabled() bool {
 	return readEnvAsBool("GENERATE_DASHBOARDS", false)
 }
 
-func GetMetricEventsConfig() bool {
+// IsMetricEventsGenerationEnabled returns whether metric events should be generated when configuring the monitoring
+func IsMetricEventsGenerationEnabled() bool {
 	return readEnvAsBool("GENERATE_METRIC_EVENTS", false)
 }
 
+// IsTaggingRulesGenerationEnabled returns whether the SSL verification is enabled or disabled
 func IsHttpSSLVerificationEnabled() bool {
 	return readEnvAsBool("HTTP_SSL_VERIFY", true)
 }

pkg/lib/dashboard.go

@@ -9,7 +9,7 @@ import (
 
 // CreateDashboard creates a new dashboard for the provided project
 func (dt *DynatraceHelper) CreateDashboard(project string, shipyard keptn.Shipyard) {
-	if !GetGenerateDashboardsConfig() {
+	if !IsDashboardsGenerationEnabled() {
 		return
 	}
 

pkg/lib/management_zones.go

@@ -9,7 +9,7 @@ import (
 
 // CreateManagementZones creates a new management zone for the project
 func (dt *DynatraceHelper) CreateManagementZones(project string, shipyard keptn.Shipyard) {
-	if !GetManagementZonesConfig() {
+	if !IsManagementZonesGenerationEnabled() {
 		return
 	}
 	// get existing management zones

pkg/lib/metric_events.go

@@ -18,7 +18,7 @@ import (
 
 // CreateMetricEvents creates new metric events if SLOs are specified
 func (dt *DynatraceHelper) CreateMetricEvents(project string, stage string, service string) {
-	if !GetMetricEventsConfig() {
+	if !IsMetricEventsGenerationEnabled() {
 		return
 	}
 

pkg/lib/problem_notifications.go

@@ -10,7 +10,7 @@ import (
 
 // EnsureProblemNotificationsAreSetUp sets up/updates the DT problem notification
 func (dt *DynatraceHelper) EnsureProblemNotificationsAreSetUp() {
-	if !GetProblemNotificationsConfig() {
+	if !IsProblemNotificationsGenerationEnabled() {
 		return
 	}