CARTO provider for cloud storage #985
Conversation
Signed-off-by: Raúl Yeguas <[email protected]>
Signed-off-by: Raúl Yeguas <[email protected]>
Signed-off-by: Raúl Yeguas <[email protected]>
Signed-off-by: Raúl Yeguas <[email protected]>
Signed-off-by: Raúl Yeguas <[email protected]>
|
|
||
| render() { | ||
| return ( | ||
| <Icons.IconWrapper {...this.props} viewBox={'0 0 92 36'}> |
There was a problem hiding this comment.
IconWrapper should pass viewBox from props, viewBox={'0 0 92 36'} shouldn't be needed here
Signed-off-by: Raúl Yeguas <[email protected]>
|
|
||
| this._carto.setClientID(clientId); | ||
|
|
||
| if (this.getAccessToken()) { |
There was a problem hiding this comment.
should it be !this.getAccessToken()?
There was a problem hiding this comment.
👍 This is not needed anymore, I deleted it
| return this.clientId !== null; | ||
| } | ||
|
|
||
| isConnected() { |
There was a problem hiding this comment.
i don't think isConnected is used anymore. in the UI we always call const isConnected = Boolean(cloudProvider.getAccessToken()
| * The CARTO cloud provider sets by the default the privacity to public | ||
| * @param {*} metadata | ||
| */ | ||
| shareFile(metadata) { |
There was a problem hiding this comment.
this method is private to dropbox, it is not called by UI
| } | ||
| } | ||
|
|
||
| getMapPermalink(mapLink, fullURL = true) { |
There was a problem hiding this comment.
no longer called by UI, can make it private
There was a problem hiding this comment.
👍 Not needed anymore, deleted
| : `/${mapLink}`; | ||
| } | ||
|
|
||
| getMapPermalinkFromParams({mapId, owner, privateMap}, fullURL = true) { |
There was a problem hiding this comment.
no longer called by UI, can make it private
Signed-off-by: Raúl Yeguas <[email protected]>
This feature allows loading/saving private and public maps using CARTO.
Related to #804