CARTO Provider for Backend Storage #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove mapId parameter from provider route
heshan0131
reviewed
Feb 11, 2020
| } | ||
|
|
||
| if (!visualization) { | ||
| throw {target: {status: 404, responseText: `Can't find map with ID: ${mapId}`}}; |
There was a problem hiding this comment.
this error will be caught on line 231, and pass to _maangeErrors, in order to get the correct message, this should be throw new Error(`Can't find map with ID: ${mapId}`)
- add dropbox user name, logout, save image - add load map from dropbox - implement load-storage-map modal and handling loadMaps in provider updater - implement save as Signed-off-by: Shan He <[email protected]>
…l into raul/backend-storage-ui
neokore
changed the base branch from
backend-storage-ui
to
provider-load-map
neokore
changed the title
heshan0131
reviewed
Feb 21, 2020
| import PropTypes from 'prop-types'; | ||
| import Base from './base'; | ||
|
|
||
| export default class Database extends Component { |
There was a problem hiding this comment.
seems like this file is not used anymore
heshan0131
reviewed
Feb 21, 2020
| @@ -44,6 +44,7 @@ export function buildAppRoutes(Component) { | |||
| <Route key="demo" path="demo"> | |||
| <IndexRoute component={Component} /> | |||
| <Route path="map" component={Component} /> | |||
| <Route path="map/:provider" component={Component} /> | |||
There was a problem hiding this comment.
Duplicate routes here, remained from rebasing
heshan0131
force-pushed
the
provider-load-map
branch
2 times, most recently
from
02b57c0 to
aed7634
Compare
|
We've simplified the PR in another branch here: #985 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows loading/saving private and public maps using CARTO.
Related to #804