[Feat] Load cloud map with provider #947

heshan0131 · 2020-02-11T01:13:57Z

This implements #943

add dropbox user name, logout, save image, list files
implement load-storage-map modal and handling loadMaps in provider updater
Signed-off-by: Shan He [email protected]

heshan0131 · 2020-02-11T01:29:30Z

kepler.gl calls provider.listMaps to get a list of visualizations shown in the load storage map gallery
when user select a visualization, kepler.gl calls provider.downloadMap and pass in theloadParams property from each visualization object
provider.downloadMap should return

    const response = {
      map: {
         datasets: [], 
         config: {},
         info: {
            title: 'test map',
            description: 'Hello this is my test dropbox map'
          }
      },
      // available option: 'csv', 'geojson', 'row', 'keplergl'
      format: 'keplergl'
    };

Each dataset should either

{data: {...}, info: {}} where data can be csv string, geojson object, or row object. You need to pass in the correspondant format to tell kepler how to process it
dataset object saved directly from KeplerGlSchema.save

ibgreen · 2020-02-24T15:44:21Z

I have a concern with how errors (exceptions) are handled in this PR.

Exceptions should be clean instances of Error constructed with a string parameter, not some arbitrary object.

I see a lot of downsides to this custom setup and no upsides. (If necessary the error instance can be annotated with additional fields like status.)

macrigiuseppe · 2020-02-25T16:48:47Z

kepler.gl calls provider.listMaps to get a list of visualizations shown in the load storage map gallery

when user select a visualization, kepler.gl calls provider.downloadMap and pass in theloadParams property from each visualization object

provider.downloadMap should return
    const response = {
      map: {
         datasets: [], 
         config: {},
         info: {
            title: 'test map',
            description: 'Hello this is my test dropbox map'
          }
      },
      // available option: 'csv', 'geojson', 'row', 'keplergl'
      format: 'keplergl'
    };
Each dataset should either

{data: {...}, info: {}} where data can be csv string, geojson object, or row object. You need to pass in the correspondant format to tell kepler how to process it

dataset object saved directly from KeplerGlSchema.save

can we add the above info to DEVELOPER.MD?

macrigiuseppe · 2020-02-25T16:57:27Z

I have a concern with how errors (exceptions) are handled in this PR.

Exceptions should be clean instances of Error constructed with a string parameter, not some arbitrary object.

I see a lot of downsides to this custom setup and no upsides. (If necessary the error instance can be annotated with additional fields like status.)

Hey @ibgreen, which part of the PR are you referring to?
Is there a particular piece of the code that you think we should look into?

Signed-off-by: Shan He <[email protected]>

macrigiuseppe · 2020-02-26T20:49:50Z

examples/demo-app/src/app.js

+    const {params: {id, provider} = {}, location: {query = {}} = {}} = this.props;
+
+    const cloudProvider = CLOUD_PROVIDERS.find(c => c.name === provider);
+    if (provider) {


if (cloudProvider)

macrigiuseppe · 2020-02-26T20:57:44Z

examples/demo-app/src/cloud-providers/dropbox/dropbox-provider.js

+    if (!token) {
+      this.login(() => this.downloadMap(loadParams));
+    }
+    const result = await this._dropbox.filesDownload(loadParams);


try/catch in case of download errors?

No need to try catch here Errors will be handled by error action passed to react-palm bimap

macrigiuseppe · 2020-02-26T21:01:50Z

examples/demo-app/src/cloud-providers/dropbox/dropbox-provider.js

+          if (thb['.tag'] === 'success' && thb.thumbnail) {
+            const matchViz = visualizations[pngs[thb.metadata.id] && pngs[thb.metadata.id].name];
+            if (matchViz) {
+              matchViz.thumbnail = `data:image/gif;base64,${thb.thumbnail}`;


let's create a constant for this prefix: data:image/gif;base64,

macrigiuseppe · 2020-02-26T21:04:29Z

examples/demo-app/src/cloud-providers/dropbox/dropbox-provider.js

+    try {
+      response = await this._dropbox.usersGetCurrentAccount();
+    } catch (error) {
+      Console.warn(error);


should we return here?

macrigiuseppe · 2020-02-26T21:15:54Z

src/components/modal-container.js

      const toSave = exportMap(this.props);
+      console.log(toSave);


remove this

macrigiuseppe · 2020-02-26T21:27:11Z

src/reducers/vis-state-updaters.js

-        (f, c) => ({
-          // using concat here because the current datasets could be an array or a single item
-          datasets: f.datasets.concat(c.datasets),
+  // const loadFileTasks = [


can we remove this?

macrigiuseppe · 2020-02-27T18:35:03Z

@heshan0131
Notes:

First time, open load from storage
When there are no items in the cloud storage, the window is not providing a clear message to users and the UI seems half baked

When saving a map:
a. The map preview is zoomed out and it doesn't provide a correct preview of the map.

b. When filling out name and description tabbing is not working, I can't jump from one field to the other and I have to use the mouse; probably tabbing doesn't work because those two inputs are not part of a form element.

Loading from storage
The cloud provider tile has a lot of white space

Loading using permalink
It looks like we lost the loading state when using permalinks (both example map or cloud storage one).

This is from our current website:

This is with the new changes

- add dropbox user name, logout, save image - add load map from dropbox - implement load-storage-map modal and handling loadMaps in provider updater - implement save as Signed-off-by: Shan He <[email protected]>

Signed-off-by: Shan He <[email protected]>

heshan0131 mentioned this pull request Feb 11, 2020

CARTO Provider for Backend Storage #922

Closed

heshan0131 force-pushed the provider-load-map branch 2 times, most recently from 37fb0a8 to 7c8c1f6 Compare February 17, 2020 04:30

ibgreen changed the base branch from backend-storage-ui to master February 17, 2020 20:57

heshan0131 force-pushed the provider-load-map branch from 3564a5a to ff8b6c6 Compare February 24, 2020 23:20

macrigiuseppe closed this Feb 25, 2020

macrigiuseppe reopened this Feb 25, 2020

update example version

77c2f32

Signed-off-by: Shan He <[email protected]>

macrigiuseppe reviewed Feb 26, 2020

View reviewed changes

src/components/modal-container.js Outdated

const toSave = exportMap(this.props);

console.log(toSave);

Copy link

Collaborator

macrigiuseppe Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

macrigiuseppe reviewed Feb 26, 2020

View reviewed changes

heshan0131 added 11 commits February 27, 2020 15:44

[Feat] Load cloud map with provider

fa99323

- add dropbox user name, logout, save image - add load map from dropbox - implement load-storage-map modal and handling loadMaps in provider updater - implement save as Signed-off-by: Shan He <[email protected]>

fix tests

6445507

Signed-off-by: Shan He <[email protected]>

fix rendering tests

32d8db5

Signed-off-by: Shan He <[email protected]>

leave only dropbox provider

330c2d3

Signed-off-by: Shan He <[email protected]>

run lint

e034f50

Signed-off-by: Shan He <[email protected]>

fix tests

be3edd6

Signed-off-by: Shan He <[email protected]>

fix overwrite not being passed correctly in save as

75e2136

Signed-off-by: Shan He <[email protected]>

create provider class and add docs

3ef6a96

Signed-off-by: Shan He <[email protected]>

cleanup demo app

2b3e22d

Signed-off-by: Shan He <[email protected]>

add loading spinner to sample maps

bdfcf4c

Signed-off-by: Shan He <[email protected]>

lint

b3d6c2a

Signed-off-by: Shan He <[email protected]>

heshan0131 added 2 commits February 27, 2020 15:45

wip

aa25fcc

Signed-off-by: Shan He <[email protected]>

address comment

aed7634

Signed-off-by: Shan He <[email protected]>

heshan0131 force-pushed the provider-load-map branch from 02b57c0 to aed7634 Compare February 27, 2020 23:52

macrigiuseppe approved these changes Feb 28, 2020

View reviewed changes

heshan0131 added 3 commits February 27, 2020 16:38

delete console

5358133

Signed-off-by: Shan He <[email protected]>

add min height

858f272

Signed-off-by: Shan He <[email protected]>

rerun test

ae5e913

Signed-off-by: Shan He <[email protected]>

heshan0131 merged commit c75812d into master Feb 28, 2020

delete-merged-branch bot deleted the provider-load-map branch February 28, 2020 06:07

heshan0131 mentioned this pull request Mar 20, 2021

Provide backend connector #409

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat] Load cloud map with provider #947

[Feat] Load cloud map with provider #947

heshan0131 commented Feb 11, 2020 •

edited by macrigiuseppe

Loading

heshan0131 commented Feb 11, 2020 •

edited

Loading

ibgreen commented Feb 24, 2020 •

edited

Loading

macrigiuseppe commented Feb 25, 2020

macrigiuseppe commented Feb 25, 2020

macrigiuseppe Feb 26, 2020

macrigiuseppe Feb 26, 2020

heshan0131 Feb 27, 2020

macrigiuseppe Feb 26, 2020

heshan0131 Feb 27, 2020

macrigiuseppe Feb 26, 2020

heshan0131 Feb 27, 2020

macrigiuseppe Feb 26, 2020

macrigiuseppe Feb 26, 2020

heshan0131 Feb 27, 2020

macrigiuseppe commented Feb 27, 2020

[Feat] Load cloud map with provider #947

[Feat] Load cloud map with provider #947

Conversation

heshan0131 commented Feb 11, 2020 • edited by macrigiuseppe Loading

heshan0131 commented Feb 11, 2020 • edited Loading

ibgreen commented Feb 24, 2020 • edited Loading

macrigiuseppe commented Feb 25, 2020

macrigiuseppe commented Feb 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

macrigiuseppe commented Feb 27, 2020

heshan0131 commented Feb 11, 2020 •

edited by macrigiuseppe

Loading

heshan0131 commented Feb 11, 2020 •

edited

Loading

ibgreen commented Feb 24, 2020 •

edited

Loading