fix alias renaming (WebOfTrust#798)

* fix alias renaming

* test added for renaming alias

* test added for renaming alias

* execution permission to the test script

scripts/demo/basic/rename-alias.sh

@@ -0,0 +1,25 @@
+#!/bin/bash
+
+# CREATE DATABASE AND KEYSTORE
+kli init --name rename-test --base "${KERI_TEMP_DIR}" --nopasscode
+
+# Incept with the initial alias "sabbir"
+kli incept --name rename-test --base "${KERI_TEMP_DIR}" --alias sabbir --file ${KERI_DEMO_SCRIPT_DIR}/data/transferable-sample.json
+
+# Rename the alias from "sabbir" to "irfan"
+kli rename --name rename-test --base "${KERI_TEMP_DIR}" --alias sabbir irfan
+
+# Extract alias from status 
+irfan_alias=$(kli status --name rename-test --base "${KERI_TEMP_DIR}" --alias irfan  | grep -Eo 'Alias:\s+(.+)' | awk '{print $2}')
+
+
+
+# Check if the extracted alias is "irfan"
+if [ "$irfan_alias" = "irfan" ]; then
+    echo "Alias successfully changed to 'irfan'."
+else
+    echo "Alias did not change !"
+
+fi
+
+echo 'Test Complete'

scripts/demo/test_scripts.sh

@@ -76,3 +76,9 @@ printf "Running multisig-join.sh"
 printf "\n************************************\n"
 "${script_dir}/basic/multisig-join.sh"
 isSuccess
+
+printf "\n************************************\n"
+printf "Running rename.sh"
+printf "\n************************************\n"
+"${script_dir}/basic/rename-alias.sh"
+isSuccess

src/keri/app/cli/commands/rename.py

@@ -48,16 +48,19 @@ def rename(tymth, tock=0.0, **opts):
             if hby.habByName(newAlias) is not None:
                 print(f"{newAlias} is already in use")
 
-            if (pre := hab.db.names.get(keys=("", name))) is not None:
+            if (pre := hab.db.names.get(keys=("", alias))) is not None:
 
                 habord = hab.db.habs.get(keys=pre)
-                habord.name = name
+                habord.name = newAlias
                 hab.db.habs.pin(keys=habord.hid,
                                 val=habord)
-                hab.db.names.pin(keys=("", name), val=pre)
+                hab.db.names.pin(keys=("", newAlias), val=pre)
                 hab.db.names.rem(keys=("", alias))
 
                 print(f"Hab {alias} renamed to {newAlias}")
+            else:
+                raise ConfigurationError(f"No AID with name {alias} found")
+
 
     except ConfigurationError as e:
         print(f"identifier prefix for {name} does not exist, incept must be run first", )