fix alias renaming #798
Merged
fix alias renaming #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to see a test added for this. |
pfeairheller
requested changes
Jun 12, 2024
|
sorry! there was an unnecessary echo. |
|
Can you please add execute permission to the new script. |
pfeairheller
approved these changes
Jun 27, 2024
kentbull
pushed a commit
to kentbull/keripy
that referenced
this pull request
Jul 8, 2024
* fix alias renaming * test added for renaming alias * test added for renaming alias * execution permission to the test script
kentbull
pushed a commit
to kentbull/keripy
that referenced
this pull request
Sep 3, 2024
* fix alias renaming * test added for renaming alias * test added for renaming alias * execution permission to the test script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when i was trying to rename with the command
kli rename --name test --base "${KERI_TEMP_DIR}" --alias <old-alias> <new-alias>i didn't get the expected result. I think this PR can fix this issue.