Fixed bug that installation failed. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the file composition has changed by the next PR of Code Igniter 4, editing of a nonexistent file and deletion of the code that is about to be copied. codeigniter4/CodeIgniter4#996
|
@ytetsuro It seems the installed CI4 does not work. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CodeIgniter4 project
rewrite.phpandserveare no longer placed in the project root directory by the following PR.Therefore, an error occurs in the code that is copying or editing.
codeigniter4/CodeIgniter4#996
In the previous PR, it depended on the directory path in
rewrite.php, butrewrite.phpno longer depends on the directory path in the following PR.codeigniter4/CodeIgniter4#1105
As a result, this codeigniter-composer-installer no longer needs to copy and edit
serveandrewrite.php.