php spark serve

[natanfelles]

Move the development server to a spark command.

Description:
   Launchs the CodeIgniter PHP-Development Server.

Usage:
   serve

Options:
   -php       The PHP Binary [default: "PHP_BINARY"]
   -host      The HTTP Host [default: "localhost"]
   -port      The HTTP Host Port [default: "8080"]

[deathart]

I'm enjoying your Pull Request (which I think is perfect).

To say that the last line of the serve file I must modify it to

Before :

passthru("{$php} -S {$host}:{$port} -t public/ rewrite.php");

After :

passthru("{$php} -S {$host}:{$port} -t public/ .../rewrite.php");

I have to add ../ before rewrite.php

(Windows)

[lonnieezell]

@natanfelles What benefit do you see by putting it behind the spark command? I debated doing it both ways when I created it, but thought it made for unnecessary overhead with no benefit at the time. Interested to hear your reasoning.

[natanfelles]

@deathart , in fact this PR should not be so perfect... But the intention is to try to improve.

@lonnieezell , the intent is to make this command more visible when the spark is executed. In addition to decreasing the number of executables outside the system and application folders.

I added the --php option thinking about the possibility of running spark by ./spark or with the spark command itself in a global context.

I do not know if application/Config/Rewrite.php is the best place to put the server router, but I thought the user might have changed the path of the Front Controller or want to pass custom $_SERVER variables, so it stayed there.

[jim-parry]

Are you referring to a "Laravel spark" (scaffolding?), or the "spark" microframework, or the long-gone Ci "spark"? I could be out of it, but I don't recall this coming up recently in a CI context.

[natanfelles]

I could refer to "Symfony Console spark", but no. Just a PR, yous decide.

[jim-parry]

Ok, I can't even find a reference to "Symfony console spark". It sounds like that could be another interpretation of the "verb/command". I see that this came up on the forum, and there was a lot of support for the term, which is unfortunate given the other possible interpretations. I didn't even think to refer to the forum until I remembered the thread on the CLI tool name :-/

[lonnieezell]

@natanfelles That's a fair point. I'm fine with moving this to a command, then. However - I'm really not a fan of having the rewrite class in Config. It's not a configuration file. It is needed to make the server work as expected, though.

I propose:

• New system\Commands\Server directory.
• Put both serve and rewrite in that folder.

Then I'll accept.