Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 22: Switch to Go modules #23

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Conversation

johandry
Copy link
Contributor

@johandry johandry commented Oct 9, 2019

Changes done:

  • Update Go modules
  • Migrate to Go 1.13.1

What was done:

# Use a new GOPATH
export GOPATH=$(mktemp -d)

# Update the Go modules
go mod tidy

# Make all
make all

How to test:
The build and all the validations done with make all are done without error.

Comments:
There was a go.mod file not updated so I think the migration to Go modules was previously done. I just update the latest modules and set Go 1.13 because there are some improvements and security fixes.

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2019

CLA assistant check
All committers have signed the CLA.

@johandry johandry changed the title Issue 22: SWi Issue 22: Switch to Go modules Oct 9, 2019
@johandry johandry mentioned this pull request Oct 9, 2019
@shrinandj shrinandj merged commit 7f625e3 into keikoproj:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants