Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to go modules #22

Closed
shrinandj opened this issue Oct 8, 2019 · 2 comments
Closed

Switch to go modules #22

shrinandj opened this issue Oct 8, 2019 · 2 comments
Labels
hacktoberfest

Comments

@shrinandj
Copy link
Collaborator

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST

What happened:
Currently, upgrade-manager uses vendor directories that are populated using dep ensure

What you expected to happen:
Since several Golang projects are switching to go modules, it might be worth investigating whether upgrade-manager should also switch to go modules. Doing this now, kinda earlier in the projects lifecycle might be easier.
@johandry
Copy link
Contributor

johandry commented Oct 9, 2019

I forked the project and open the PR #23.
It was basically all done regarding modules, the only change is basically upgrade to Go 1.13.

If the PR is not merged, I think this issue should be closed.

@kianjones4
Copy link
Collaborator

closed by #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johandry @shrinandj @kianjones4