Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation for provisioner type #267

Merged

Conversation

eytan-avisror
Copy link
Collaborator

Signed-off-by: Eytan Avisror [email protected]
Fixes #261

@eytan-avisror eytan-avisror requested review from a team as code owners April 1, 2021 00:38
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #267 (403628d) into master (01893a7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          17       17           
  Lines        2256     2256           
=======================================
  Hits         1980     1980           
  Misses        173      173           
  Partials      103      103           
Impacted Files Coverage Δ
controllers/provisioners/eksfargate/eksfargate.go 94.23% <100.00%> (ø)
controllers/provisioners/eksmanaged/eksmanaged.go 85.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01893a7...403628d. Read the comment docs.

@eytan-avisror eytan-avisror changed the title Fix: validation for provisioner type fix: validation for provisioner type Apr 1, 2021
@eytan-avisror eytan-avisror merged commit 052aaa3 into keikoproj:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation: Add validation for Provisioner
2 participants